Merge pull request #6938 from hasnainvirk/style_and_bug_fixes

LoRaWAN: Style and bug fixes

Author: Cruz Monrreal

features/lorawan/LoRaWANBase.h

@@ -217,7 +217,7 @@ class LoRaWANBase {
      *                          LORAWAN_STATUS_WOULD_BLOCK if another TX is
      *                          ongoing, or a negative error code on failure.
      */
-    virtual int16_t send(uint8_t port, const uint8_t* data,
+    virtual int16_t send(uint8_t port, const uint8_t *data,
                          uint16_t length, int flags) = 0;
 
     /** Receives a message from the Network Server on a specific port.
@@ -259,7 +259,7 @@ class LoRaWANBase {
      *                                  nothing available to read at the moment.
      *                             iv)  A negative error code on failure.
      */
-    virtual int16_t receive(uint8_t port, uint8_t* data, uint16_t length, int flags) = 0;
+    virtual int16_t receive(uint8_t port, uint8_t *data, uint16_t length, int flags) = 0;
 
     /** Receives a message from the Network Server from any port.
      *
@@ -283,7 +283,7 @@ class LoRaWANBase {
      *                                  nothing available to read at the moment.
      *                             iv)  A negative error code on failure.
      */
-    virtual int16_t receive(uint8_t* data, uint16_t length, uint8_t& port, int& flags) = 0;
+    virtual int16_t receive(uint8_t *data, uint16_t length, uint8_t &port, int &flags) = 0;
 
     /** Add application callbacks to the stack.
      *

features/lorawan/LoRaWANInterface.cpp

@@ -23,7 +23,7 @@
 
 using namespace events;
 
-LoRaWANInterface::LoRaWANInterface(LoRaRadio& radio)
+LoRaWANInterface::LoRaWANInterface(LoRaRadio &radio)
 {
     _lw_stack.bind_radio_driver(radio);
 }
@@ -116,7 +116,7 @@ lorawan_status_t LoRaWANInterface::remove_channel_plan()
     return _lw_stack.drop_channel_list();
 }
 
-int16_t LoRaWANInterface::send(uint8_t port, const uint8_t* data, uint16_t length, int flags)
+int16_t LoRaWANInterface::send(uint8_t port, const uint8_t *data, uint16_t length, int flags)
 {
     Lock lock(*this);
     return _lw_stack.handle_tx(port, data, length, flags);
@@ -146,13 +146,13 @@ lorawan_status_t LoRaWANInterface::get_backoff_metadata(int &backoff)
     return _lw_stack.acquire_backoff_metadata(backoff);
 }
 
-int16_t LoRaWANInterface::receive(uint8_t port, uint8_t* data, uint16_t length, int flags)
+int16_t LoRaWANInterface::receive(uint8_t port, uint8_t *data, uint16_t length, int flags)
 {
     Lock lock(*this);
     return _lw_stack.handle_rx(data, length, port, flags, true);
 }
 
-int16_t LoRaWANInterface::receive(uint8_t* data, uint16_t length, uint8_t& port, int& flags)
+int16_t LoRaWANInterface::receive(uint8_t *data, uint16_t length, uint8_t &port, int &flags)
 {
     Lock lock(*this);
     return _lw_stack.handle_rx(data, length, port, flags, false);

features/lorawan/LoRaWANInterface.h

@@ -34,7 +34,7 @@ class LoRaWANInterface: public LoRaWANBase {
      * construct a single instance of LoRaWANInterface.
      *
      */
-    LoRaWANInterface(LoRaRadio& radio);
+    LoRaWANInterface(LoRaRadio &radio);
 
     virtual ~LoRaWANInterface();
 
@@ -315,7 +315,7 @@ class LoRaWANInterface: public LoRaWANBase {
      *                          LORAWAN_STATUS_WOULD_BLOCK if another TX is
      *                          ongoing, or a negative error code on failure.
      */
-    virtual int16_t send(uint8_t port, const uint8_t* data, uint16_t length,
+    virtual int16_t send(uint8_t port, const uint8_t *data, uint16_t length,
                          int flags);
 
     /** Receives a message from the Network Server on a specific port.
@@ -357,7 +357,7 @@ class LoRaWANInterface: public LoRaWANBase {
      *                                  nothing available to read at the moment.
      *                             iv)  A negative error code on failure.
      */
-    virtual int16_t receive(uint8_t port, uint8_t* data, uint16_t length, int flags);
+    virtual int16_t receive(uint8_t port, uint8_t *data, uint16_t length, int flags);
 
     /** Receives a message from the Network Server on any port.
      *
@@ -381,7 +381,7 @@ class LoRaWANInterface: public LoRaWANBase {
      *                                  nothing available to read at the moment.
      *                             iv)  A negative error code on failure.
      */
-    virtual int16_t receive(uint8_t* data, uint16_t length, uint8_t& port, int& flags);
+    virtual int16_t receive(uint8_t *data, uint16_t length, uint8_t &port, int &flags);
 
     /** Add application callbacks to the stack.
      *
@@ -502,8 +502,14 @@ class LoRaWANInterface: public LoRaWANBase {
      */
     virtual lorawan_status_t cancel_sending(void);
 
-    void lock(void) { _lw_stack.lock(); }
-    void unlock(void) { _lw_stack.unlock(); }
+    void lock(void)
+    {
+        _lw_stack.lock();
+    }
+    void unlock(void)
+    {
+        _lw_stack.unlock();
+    }
 
 
 private: