Verifying datarate bug fix

Hasnain Virk · Hasnain Virk · commit b163057da736 · 2018-02-20T15:08:04.000+02:00
A patch was missed from the feature PR.
verify_channel_DR() in LoRaPHY class had a loop with uninitialized
loop counter.
diff --git a/features/lorawan/lorastack/phy/LoRaPHY.cpp b/features/lorawan/lorastack/phy/LoRaPHY.cpp
@@ -159,7 +159,7 @@ bool LoRaPHY::verify_channel_DR(uint8_t nb_channels, uint16_t* channel_mask,
         return false;
     }
 
-    for (uint8_t i; i < phy_params.max_channel_cnt; i++) {
+    for (uint8_t i = 0; i < phy_params.max_channel_cnt; i++) {
         if (mask_bit_test(channel_mask, i)) {
             // Check datarate validity for enabled channels
             if (val_in_range(dr, (channels[i].dr_range.fields.min & 0x0F),

Original file line number	Diff line number	Diff line change
`@@ -159,7 +159,7 @@ bool LoRaPHY::verify_channel_DR(uint8_t nb_channels, uint16_t* channel_mask,`
`159`	`159`	`return false;`
`160`	`160`	`}`
`161`	`161`
`162`		`- for (uint8_t i; i < phy_params.max_channel_cnt; i++) {`
	`162`	`+ for (uint8_t i = 0; i < phy_params.max_channel_cnt; i++) {`
`163`	`163`	`if (mask_bit_test(channel_mask, i)) {`
`164`	`164`	`// Check datarate validity for enabled channels`
`165`	`165`	`if (val_in_range(dr, (channels[i].dr_range.fields.min & 0x0F),`