Cellular: Add AT handler buffer size to configuration

Author: boraozgen

connectivity/cellular/include/cellular/framework/API/ATHandler.h

@@ -50,8 +50,6 @@ class FileHandle;
 extern const char *OK;
 extern const char *CRLF;
 
-#define BUFF_SIZE 32
-
 /* AT Error types enumeration */
 enum DeviceErrorType {
     DeviceErrorTypeNoError = 0,
@@ -114,7 +112,7 @@ class ATHandler {
 
     /** Set callback function for URC
      *
-     *  @param prefix   URC text to look for, e.g. "+CMTI:". Maximum length is BUFF_SIZE.
+     *  @param prefix   URC text to look for, e.g. "+CMTI:". Maximum length is MBED_CONF_CELLULAR_AT_HANDLER_BUFFER_SIZE.
      *  @param callback function to call on prefix, or 0 to remove callback
      */
     void set_urc_handler(const char *prefix, Callback<void()> callback);
@@ -601,7 +599,7 @@ class ATHandler {
     bool _is_fh_usable;
 
     // should fit any prefix and int
-    char _recv_buff[BUFF_SIZE];
+    char _recv_buff[MBED_CONF_CELLULAR_AT_HANDLER_BUFFER_SIZE];
     // reading position
     size_t _recv_len;
     // reading length
@@ -630,7 +628,7 @@ class ATHandler {
     size_t _max_resp_length;
 
     // prefix set during resp_start and used to try matching possible information responses
-    char _info_resp_prefix[BUFF_SIZE];
+    char _info_resp_prefix[MBED_CONF_CELLULAR_AT_HANDLER_BUFFER_SIZE];
     bool _debug_on;
     bool _cmd_start;
     bool _use_delimiter;
@@ -640,7 +638,7 @@ class ATHandler {
     // eventqueue event id
     int _event_id;
 
-    char _cmd_buffer[BUFF_SIZE];
+    char _cmd_buffer[MBED_CONF_CELLULAR_AT_HANDLER_BUFFER_SIZE];
 };
 
 } // namespace mbed

connectivity/cellular/mbed_lib.json

@@ -44,6 +44,10 @@
         "plmn-fallback-auto" : {
             "help": "If manual PLMN is selected, use mode 4 manual/automatic in AT+COPS to try automatic mode if manual selection fails. Set to null to disable",
             "value": null
+        },
+        "at-handler-buffer-size" : {
+            "help": "Size of the AT handler buffer",
+            "value": 32
         }
     }
 }

connectivity/cellular/source/framework/device/ATHandler.cpp

@@ -683,7 +683,7 @@ int32_t ATHandler::read_int()
         return -1;
     }
 
-    char buff[BUFF_SIZE];
+    char buff[MBED_CONF_CELLULAR_AT_HANDLER_BUFFER_SIZE];
     if (read_string(buff, sizeof(buff)) == 0) {
         return -1;
     }
@@ -960,7 +960,7 @@ void ATHandler::resp_start(const char *prefix, bool stop)
     (void)fill_buffer(false);
 
     if (prefix) {
-        MBED_ASSERT(strlen(prefix) < BUFF_SIZE);
+        MBED_ASSERT(strlen(prefix) < MBED_CONF_CELLULAR_AT_HANDLER_BUFFER_SIZE);
         strcpy(_info_resp_prefix, prefix); // copy prefix so we can later use it without having to provide again for info_resp
     }
 
@@ -1225,7 +1225,7 @@ void ATHandler::handle_start(const char *cmd, const char *cmd_chr)
     if (cmd_chr) {
         cmd_char_len = strlen(cmd_chr);
     }
-    MBED_ASSERT((3 + strlen(cmd) + cmd_char_len) < BUFF_SIZE);
+    MBED_ASSERT((3 + strlen(cmd) + cmd_char_len) < MBED_CONF_CELLULAR_AT_HANDLER_BUFFER_SIZE);
 
     memcpy(_cmd_buffer + len, cmd, strlen(cmd));
     len += strlen(cmd);
@@ -1258,7 +1258,7 @@ void ATHandler::cmd_start_stop(const char *cmd, const char *cmd_chr, const char
 
 nsapi_error_t ATHandler::at_cmd_str(const char *cmd, const char *cmd_chr, char *resp_buf, size_t buf_size, const char *format, ...)
 {
-    MBED_ASSERT(strlen(cmd) < BUFF_SIZE);
+    MBED_ASSERT(strlen(cmd) < MBED_CONF_CELLULAR_AT_HANDLER_BUFFER_SIZE);
     lock();
 
     handle_start(cmd, cmd_chr);

connectivity/cellular/tests/UNITTESTS/framework/AT/at_cellularcontext/unittest.cmake

@@ -51,4 +51,5 @@ set(unittest-test-flags
   -DMBED_CONF_CELLULAR_USE_SMS=1
   -DMBED_CONF_NSAPI_DEFAULT_CELLULAR_APN=NULL
   -DMBED_CONF_PLATFORM_DEFAULT_SERIAL_BAUD_RATE=115200
+  -DMBED_CONF_CELLULAR_AT_HANDLER_BUFFER_SIZE=32
 )

connectivity/cellular/tests/UNITTESTS/framework/AT/at_cellularinformation/unittest.cmake

@@ -40,4 +40,5 @@ set(unittest-test-flags
   -DDEVICE_SERIAL=1
   -DDEVICE_INTERRUPTIN=1
   -DMBED_CONF_PLATFORM_DEFAULT_SERIAL_BAUD_RATE=115200
+  -DMBED_CONF_CELLULAR_AT_HANDLER_BUFFER_SIZE=32
 )

connectivity/cellular/tests/UNITTESTS/framework/AT/at_cellularnetwork/unittest.cmake

@@ -42,4 +42,5 @@ set(unittest-test-flags
   -DDEVICE_SERIAL=1
   -DDEVICE_INTERRUPTIN=1
   -DMBED_CONF_PLATFORM_DEFAULT_SERIAL_BAUD_RATE=115200
+  -DMBED_CONF_CELLULAR_AT_HANDLER_BUFFER_SIZE=32
 )

connectivity/cellular/tests/UNITTESTS/framework/AT/at_cellularsms/unittest.cmake

@@ -44,4 +44,5 @@ set(unittest-test-flags
   -DDEVICE_SERIAL=1
   -DDEVICE_INTERRUPTIN=1
   -DMBED_CONF_PLATFORM_DEFAULT_SERIAL_BAUD_RATE=115200
+  -DMBED_CONF_CELLULAR_AT_HANDLER_BUFFER_SIZE=32
 )

connectivity/cellular/tests/UNITTESTS/framework/AT/at_cellularstack/unittest.cmake

@@ -49,4 +49,5 @@ set(unittest-test-flags
   -DDEVICE_SERIAL=1
   -DDEVICE_INTERRUPTIN=1
   -DMBED_CONF_PLATFORM_DEFAULT_SERIAL_BAUD_RATE=115200
+  -DMBED_CONF_CELLULAR_AT_HANDLER_BUFFER_SIZE=32
 )

connectivity/cellular/tests/UNITTESTS/framework/device/athandler/unittest.cmake

@@ -45,4 +45,5 @@ set(unittest-test-flags
   -DDEVICE_SERIAL=1
   -DDEVICE_INTERRUPTIN=1
   -DMBED_CONF_PLATFORM_DEFAULT_SERIAL_BAUD_RATE=115200
+  -DMBED_CONF_CELLULAR_AT_HANDLER_BUFFER_SIZE=32
 )

connectivity/cellular/tests/UNITTESTS/framework/device/cellularcontext/unittest.cmake

@@ -56,4 +56,5 @@ set(unittest-test-flags
   -DDEVICE_SERIAL=1
   -DDEVICE_INTERRUPTIN=1
   -DMBED_CONF_CELLULAR_USE_SMS=1
+  -DMBED_CONF_CELLULAR_AT_HANDLER_BUFFER_SIZE=32
 )

connectivity/cellular/tests/UNITTESTS/framework/device/cellulardevice/unittest.cmake

@@ -47,4 +47,5 @@ set(unittest-test-flags
   -DDEVICE_SERIAL_FC=1
   -DDEVICE_SERIAL=1
   -DDEVICE_INTERRUPTIN=1
+  -DMBED_CONF_CELLULAR_AT_HANDLER_BUFFER_SIZE=32
 )

connectivity/cellular/tests/UNITTESTS/framework/device/cellularstatemachine/unittest.cmake

@@ -52,4 +52,5 @@ set(unittest-test-flags
   -DDEVICE_SERIAL=1
   -DDEVICE_INTERRUPTIN=1
   -DMBED_CONF_CELLULAR_USE_SMS=1
+  -DMBED_CONF_CELLULAR_AT_HANDLER_BUFFER_SIZE=32
 )