Skip to content

Commit cbaa9bd

Browse files
authored
Merge pull request #12198 from rajkan01/bug_fix_uARM_depreciate
uARM: Fix deprecate warning printing wrongly for GCC_ARM/IAR toolchain build
2 parents 4cdd803 + 434f50e commit cbaa9bd

File tree

2 files changed

+10
-7
lines changed

2 files changed

+10
-7
lines changed

tools/build_api.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -234,17 +234,20 @@ def find_valid_toolchain(target, toolchain):
234234
last_error = None
235235
for index, toolchain_name in enumerate(toolchain_names):
236236
internal_tc_name = get_toolchain_name(target, toolchain_name)
237-
if toolchain == "ARM" and toolchain_name == "ARMC5" and index != 0:
238-
end_warnings.append(ARMC5_MIGRATION_WARNING)
239237
if not TOOLCHAIN_CLASSES[internal_tc_name].check_executable():
240238
search_path = TOOLCHAIN_PATHS[internal_tc_name] or "No path set"
241239
last_error = (
242240
"Could not find executable for {}.\n"
243241
"Currently set search path: {}"
244242
).format(toolchain_name, search_path)
245-
else:
246-
if toolchain_name == "uARM" or target.default_toolchain == "uARM":
247-
end_warnings.append(UARM_TOOLCHAIN_WARNING)
243+
else:
244+
if toolchain_name == "ARMC5":
245+
end_warnings.append(ARMC5_MIGRATION_WARNING)
246+
if (
247+
toolchain_name in ["uARM", "ARMC5", "ARMC6"]
248+
and "uARM" in {toolchain_name, target.default_toolchain}
249+
):
250+
end_warnings.append(UARM_TOOLCHAIN_WARNING)
248251
return toolchain_name, internal_tc_name, end_warnings
249252
else:
250253
if last_error:

tools/toolchains/arm.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@
3838
)
3939

4040
UARM_TOOLCHAIN_WARNING = (
41-
"Warning: We noticed that you are using uARM Toolchain. "
42-
"We are deprecating the use of uARM Toolchain. "
41+
"Warning: We noticed that you are using uARM Toolchain either via --toolchain command line or default_toolchain option. "
42+
"We are deprecating the use of the uARM Toolchain. "
4343
"For more information on how to use the ARM toolchain with small C libraries, "
4444
"please visit https://os.mbed.com/docs/mbed-os/latest/reference/using-small-c-libraries.html"
4545
)

0 commit comments

Comments
 (0)