Skip to content

Commit ce775d5

Browse files
committed
BLE HealthThermometerService: correct GATT characteristics
As per official specification, temperature measurement requires the GATT characteristic "INDICATE" instead of "NOTIFY". Full credits to Jean-Marc Jobin (@jmjobin on GitHub) for identifying the issue and proposing this fix.
1 parent 1dbb478 commit ce775d5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

features/FEATURE_BLE/ble/services/HealthThermometerService.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ class HealthThermometerService {
5555
HealthThermometerService(BLE &_ble, float initialTemp, uint8_t _location) :
5656
ble(_ble),
5757
valueBytes(initialTemp),
58-
tempMeasurement(GattCharacteristic::UUID_TEMPERATURE_MEASUREMENT_CHAR, (TemperatureValueBytes *)valueBytes.getPointer(), GattCharacteristic::BLE_GATT_CHAR_PROPERTIES_NOTIFY),
58+
tempMeasurement(GattCharacteristic::UUID_TEMPERATURE_MEASUREMENT_CHAR, (TemperatureValueBytes *)valueBytes.getPointer(), GattCharacteristic::BLE_GATT_CHAR_PROPERTIES_INDICATE),
5959
tempLocation(GattCharacteristic::UUID_TEMPERATURE_TYPE_CHAR, &_location) {
6060

6161
GattCharacteristic *hrmChars[] = {&tempMeasurement, &tempLocation, };

0 commit comments

Comments
 (0)