Skip to content

Commit d56c8ca

Browse files
author
Teppo Järvelin
committed
Cellular: fixed compile warnings from cellular
1 parent 2f1338b commit d56c8ca

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

features/cellular/framework/device/CellularContext.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ void CellularContext::do_connect_with_retry()
7777
{
7878
if (_cb_data.final_try) {
7979
_cb_data.final_try = false;
80-
_cb_data.error == NSAPI_ERROR_NO_CONNECTION;
80+
_cb_data.error = NSAPI_ERROR_NO_CONNECTION;
8181
call_network_cb(NSAPI_STATUS_DISCONNECTED);
8282
return;
8383
}

features/cellular/framework/device/CellularDevice.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -181,14 +181,14 @@ void CellularDevice::stm_callback(nsapi_event_t ev, intptr_t ptr)
181181
void CellularDevice::cellular_callback(nsapi_event_t ev, intptr_t ptr, CellularContext *ctx)
182182
{
183183
if (ev >= NSAPI_EVENT_CELLULAR_STATUS_BASE && ev <= NSAPI_EVENT_CELLULAR_STATUS_END) {
184-
cell_callback_data_t *ptr_data = (cell_callback_data_t *)ptr;
185184
cellular_connection_status_t cell_ev = (cellular_connection_status_t)ev;
185+
cell_callback_data_t *ptr_data = (cell_callback_data_t *)ptr;
186+
(void)ptr_data; // avoid compile warning, used only for debugging
186187
if (cell_ev == CellularStateRetryEvent) {
187188
tr_debug("callback: CellularStateRetryEvent, err: %d, data: %d, retrycount: %d", ptr_data->error, ptr_data->status_data, *(const int *)ptr_data->data);
188189
} else {
189190
tr_debug("callback: %d, err: %d, data: %d", ev, ptr_data->error, ptr_data->status_data);
190191
}
191-
192192
if (cell_ev == CellularRegistrationStatusChanged && _state_machine) {
193193
// broadcast only network registration changes to state machine
194194
_state_machine->cellular_event_changed(ev, ptr);

features/cellular/framework/targets/QUECTEL/BG96/QUECTEL_BG96_CellularStack.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ void QUECTEL_BG96_CellularStack::urc_qiurc()
118118
{
119119
char urc_string[MAX_QIURC_LENGTH + 1];
120120
_at.lock();
121-
const int urc_string_length = _at.read_string(urc_string, sizeof(urc_string));
121+
(void)_at.read_string(urc_string, sizeof(urc_string));
122122
const int sock_id = _at.read_int();
123123
const nsapi_error_t err = _at.unlock_return_error();
124124

features/cellular/framework/targets/QUECTEL/M26/QUECTEL_M26_CellularStack.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -490,6 +490,7 @@ nsapi_size_or_error_t QUECTEL_M26_CellularStack::socket_sendto_impl(CellularSock
490490
_at.resp_start("+QISACK:");
491491
sent_len_after = _at.read_int();
492492
sent_acked = _at.read_int();
493+
(void)sent_acked; // avoid compile warning, used only for debugging
493494
sent_nacked = _at.read_int();
494495
_at.resp_stop();
495496

@@ -526,7 +527,7 @@ nsapi_size_or_error_t QUECTEL_M26_CellularStack::socket_recvfrom_impl(CellularSo
526527
uint64_t start_time = rtos::Kernel::get_ms_count();
527528
nsapi_size_t len = 0;
528529
for (; len < size;) {
529-
int read_len = (size - len > M26_RECV_BYTE_MAX) ? M26_RECV_BYTE_MAX : size - len;
530+
unsigned int read_len = (size - len > M26_RECV_BYTE_MAX) ? M26_RECV_BYTE_MAX : size - len;
530531
_at.cmd_start("AT+QIRD=");
531532
_at.write_int(0); /* at+qifgcnt 0-1 */
532533
_at.write_int(1); /* 1-Client, 2-Server */

0 commit comments

Comments
 (0)