MAC, RPL and ETX trace clean.

Juha Heiskanen · Juha Heiskanen · commit da5d2c7bea01 · 2019-07-04T10:58:13.000+03:00
Change-Id: I4bdf63e277b2301bf779483b116b63e2f65f4d91
diff --git a/source/MAC/IEEE802_15_4/mac_indirect_data.c b/source/MAC/IEEE802_15_4/mac_indirect_data.c
@@ -148,7 +148,6 @@ uint8_t mac_indirect_data_req_handle(mac_pre_parsed_frame_t *buf, protocol_inter
 
     /* If the Ack we sent for the Data Request didn't have frame pending set, we shouldn't transmit - child may have slept */
     if (!buf->ack_pendinfg_status) {
-        //tr_debug("Drop by pending");
         if (mac_ptr->indirect_pd_data_request_queue) {
             tr_error("Wrongly dropped");
         }
diff --git a/source/MAC/IEEE802_15_4/mac_mcps_sap.c b/source/MAC/IEEE802_15_4/mac_mcps_sap.c
@@ -235,7 +235,6 @@ void mcps_sap_data_req_handler_ext(protocol_interface_rf_mac_setup_s *rf_mac_set
 
     if (!rf_mac_setup->macUpState || rf_mac_setup->scan_active) {
         status = MLME_TRX_OFF;
-        tr_debug("Drop MAC tx packet when mac disabled");
         goto verify_status;
     }
 
@@ -616,11 +615,6 @@ static uint8_t mac_data_interface_decrypt_packet(mac_pre_parsed_frame_t *b, mlme
     ccm_ptr.data_ptr = (mcps_mac_payload_pointer_get(b) + openPayloadLength);
     ccm_ptr.data_len = b->mac_payload_length - openPayloadLength;
     if (ccm_process_run(&ccm_ptr) != 0) {
-        tr_warning("MIC Fail adata %s", trace_array(ccm_ptr.adata_ptr, ccm_ptr.adata_len));
-        tr_warning("Nonce %s", trace_array(ccm_ptr.exp_nonce, 13));
-        if (openPayloadLength) {
-            tr_warning("%s", tr_array(ccm_ptr.data_ptr,  ccm_ptr.data_len));
-        }
         return MLME_SECURITY_FAIL;
     }
 
@@ -662,7 +656,6 @@ static void mcps_comm_status_indication_generate(uint8_t status, mac_pre_parsed_
 static int8_t mac_data_interface_host_accept_data(mcps_data_ind_t *data_ind, protocol_interface_rf_mac_setup_s *rf_mac_setup)
 {
     if ((data_ind->DstAddrMode == MAC_ADDR_MODE_16_BIT) && (data_ind->DstAddr[0] == 0xff && data_ind->DstAddr[1] == 0xff)) {
-        tr_debug("Drop Multicast packet");
         return -1;
     }
 
@@ -723,7 +716,6 @@ static int8_t mac_data_sap_rx_handler(mac_pre_parsed_frame_t *buf, protocol_inte
     }
 
     if (!mac_payload_information_elements_parse(buf)) {
-        tr_debug("Drop by Paylod IE");
         goto DROP_PACKET;
     }
     data_ind->msduLength = buf->mac_payload_length;
@@ -741,7 +733,6 @@ static int8_t mac_data_sap_rx_handler(mac_pre_parsed_frame_t *buf, protocol_inte
 
         if (buf->fcf_dsn.frameVersion == MAC_FRAME_VERSION_2015) {
             if (!rf_mac_setup->mac_extension_enabled) {
-                tr_debug("No Ext reg");
                 goto DROP_PACKET;
             }
             mcps_data_ie_list_t ie_list;
@@ -903,7 +894,6 @@ static void mac_data_interface_parse_beacon(mac_pre_parsed_frame_t *buf, protoco
     }
 
     if (!mac_payload_information_elements_parse(buf)) {
-        tr_debug("Drop by Paylod IE");
         return;
     }
 
@@ -924,7 +914,6 @@ static void mac_data_interface_parse_beacon(mac_pre_parsed_frame_t *buf, protoco
         if (len < gts_field_length) {
             return;
         }
-//        gts_info = ptr;
         len -= gts_field_length;
         ptr += gts_field_length;
     }
@@ -979,7 +968,6 @@ static void mac_data_interface_frame_handler(mac_pre_parsed_frame_t *buf)
 {
     protocol_interface_rf_mac_setup_s *rf_mac_setup = buf->mac_class_ptr;
     if (!rf_mac_setup) {
-        tr_debug("Drop by no mac class");
         mcps_sap_pre_parsed_frame_buffer_free(buf);
         return;
     }
@@ -1084,13 +1072,11 @@ static int8_t mac_ack_sap_rx_handler(mac_pre_parsed_frame_t *buf, protocol_inter
     if (buf->fcf_dsn.securityEnabled) {
         uint8_t status = mac_data_interface_decrypt_packet(buf, &key);
         if (status != MLME_SUCCESS) {
-            tr_debug("ACK Decrypt fail");
             return -1;
         }
     }
 
     if (buf->mac_payload_length && !mac_payload_information_elements_parse(buf)) {
-        tr_debug("Drop ACK by Paylod IE");
         return -1;
     }
 
diff --git a/source/MAC/IEEE802_15_4/mac_mlme.c b/source/MAC/IEEE802_15_4/mac_mlme.c
@@ -232,7 +232,6 @@ uint8_t mac_mlme_beacon_req_tx(protocol_interface_rf_mac_setup_s *rf_ptr)
         buf->fcf_dsn.DstPanPresents = true;
         buf->fcf_dsn.SrcPanPresents = false;
 
-        tr_debug("BEA REQ tx");
         mcps_sap_pd_req_queue_write(rf_ptr, buf);
         return 1;
     }
@@ -843,7 +842,6 @@ static void mlme_scan_operation(protocol_interface_rf_mac_setup_s *rf_mac_setup)
     channel = mlme_scan_analyze_next_channel(&rf_mac_setup->mac_channel_list, true);
     if (channel > 0xff || rf_mac_setup->mac_mlme_scan_resp->ResultListSize == MLME_MAC_RES_SIZE_MAX) {
         resp->status = MLME_SUCCESS;
-        tr_debug("Scan Complete..Halt MAC");
         platform_enter_critical();
         mac_mlme_mac_radio_disabled(rf_mac_setup);
         if (resp->ResultListSize == 0 && rf_mac_setup->scan_type == MAC_ACTIVE_SCAN) {
@@ -855,7 +853,6 @@ static void mlme_scan_operation(protocol_interface_rf_mac_setup_s *rf_mac_setup)
         platform_exit_critical();
         //Scan Confirmation
         mac_generic_event_trig(MAC_MLME_SCAN_CONFIRM_HANDLER, rf_mac_setup, false);
-        tr_debug("Trig confirm");
         rf_mac_setup->scan_active = false;
     } else {
         mac_mlme_scan_init((uint8_t) channel, rf_mac_setup);
@@ -987,20 +984,17 @@ static void mac_mlme_free_scan_temporary_data(protocol_interface_rf_mac_setup_s
     rf_mac_setup->scan_active = false;
     if (rf_mac_setup->mac_mlme_scan_resp) {
         mlme_scan_conf_t *r = rf_mac_setup->mac_mlme_scan_resp;
-        tr_debug("%02x", r->ResultListSize);
         if (r->ED_values) {
             ns_dyn_mem_free(r->ED_values);
             r->ED_values = NULL;
         }
         uint8_t i = 0;
         while (i < r->ResultListSize) {
             if (r->PAN_values[i]) {
-                tr_debug("Free PAN result");
                 ns_dyn_mem_free(r->PAN_values[i]);
             }
             i++;
         }
-        tr_debug("Free Response");
         ns_dyn_mem_free(rf_mac_setup->mac_mlme_scan_resp);
         rf_mac_setup->mac_mlme_scan_resp = NULL;
     }
@@ -1399,11 +1393,6 @@ static void mac_mlme_start_confirm_handler(protocol_interface_rf_mac_setup_s *rf
 
 static void mac_mlme_scan_confirm_handler(protocol_interface_rf_mac_setup_s *rf_ptr, const mlme_scan_conf_t *conf)
 {
-    if (conf->ScanType == MAC_ACTIVE_SCAN) {
-        tr_debug("Active Scan Result");
-    } else if (conf->ScanType == MAC_ED_SCAN_TYPE) {
-        tr_debug("ED Scan Result");
-    }
     if (rf_ptr->tun_extension_rf_driver) {
         virtual_data_req_t scan_conf;
         uint8_t buf_temp[2];
diff --git a/source/RPL/rpl_control.c b/source/RPL/rpl_control.c
@@ -856,7 +856,6 @@ static void rpl_control_dao_trigger_request(rpl_instance_t *instance, rpl_dodag_
 static buffer_t *rpl_control_dio_handler(protocol_interface_info_entry_t *cur, rpl_domain_t *domain, buffer_t *buf)
 {
     if (!rpl_control_options_well_formed_in_buffer(buf, 24)) {
-        tr_error("DIO format");
 malformed:
         protocol_stats_update(STATS_RPL_MALFORMED_MESSAGE, 1);
         return buffer_free(buf);
@@ -1268,7 +1267,6 @@ void rpl_control_transmit_dio(rpl_domain_t *domain, protocol_interface_info_entr
 static buffer_t *rpl_control_dis_handler(protocol_interface_info_entry_t *cur, rpl_domain_t *domain, buffer_t *buf, bool multicast)
 {
     if (!rpl_control_options_well_formed_in_buffer(buf, 2)) {
-        tr_error("DIS format");
         protocol_stats_update(STATS_RPL_MALFORMED_MESSAGE, 1);
         return buffer_free(buf);
     }
@@ -1396,7 +1394,6 @@ static buffer_t *rpl_control_dao_ack_handler(protocol_interface_info_entry_t *cu
 
     if (buffer_data_length(buf) < 4) {
 format_error:
-        tr_error("DAO-ACK format");
         protocol_stats_update(STATS_RPL_MALFORMED_MESSAGE, 1);
         return buffer_free(buf);
     }
@@ -1480,7 +1477,6 @@ static buffer_t *rpl_control_dao_handler(protocol_interface_info_entry_t *cur, r
 {
     if (buffer_data_length(buf) < 4) {
 format_error:
-        tr_error("DAO format");
         protocol_stats_update(STATS_RPL_MALFORMED_MESSAGE, 1);
         return buffer_free(buf);
     }
diff --git a/source/RPL/rpl_downward.c b/source/RPL/rpl_downward.c
@@ -389,7 +389,7 @@ void rpl_instance_dao_trigger(rpl_instance_t *instance, uint16_t delay)
     }
     if (instance->delay_dao_timer == 0 || instance->delay_dao_timer > delay) {
         instance->delay_dao_timer = delay;
-        tr_debug("DAO trigger %" PRIu16, delay);
+        //tr_debug("DAO trigger %" PRIu16, delay);
     }
 }
 
diff --git a/source/Service_Libs/etx/etx.c b/source/Service_Libs/etx/etx.c
@@ -157,7 +157,7 @@ static bool etx_update_possible(etx_sample_storage_t *storage, etx_storage_t *en
         }
     }
 
-    tr_debug("ETX update possible %u attempts, %u rx ack", storage->attempts_count, storage->received_acks);
+    //tr_debug("ETX update possible %u attempts, %u rx ack", storage->attempts_count, storage->received_acks);
 
     return true;
 
@@ -318,9 +318,6 @@ uint16_t etx_read(int8_t interface_id, addrtype_t addr_type, const uint8_t *addr
     }
     attribute_index = mac_neighbor->index;
 
-
-    //tr_debug("Etx Read from atribute %u", attribute_index);
-
     etx_storage_t *entry = etx_storage_entry_get(interface_id, attribute_index);
 
     if (!entry) {
@@ -330,8 +327,6 @@ uint16_t etx_read(int8_t interface_id, addrtype_t addr_type, const uint8_t *addr
     uint16_t etx  = etx_current_calc(entry->etx, entry->accumulated_failures);
     etx >>= 4;
 
-    //tr_debug("Etx value %u", etx);
-
     return etx;
 }
 
@@ -632,7 +627,6 @@ void etx_max_update_set(uint16_t etx_max_update)
 etx_storage_t *etx_storage_entry_get(int8_t interface_id, uint8_t attribute_index)
 {
     if (etx_info.interface_id != interface_id || !etx_info.etx_storage_list || attribute_index >= etx_info.ext_storage_list_size) {
-        //tr_debug("Unknow ID or un initilized ETX %u", attribute_index);
         return NULL;
     }
 
@@ -804,12 +798,7 @@ void etx_cache_timer(int8_t interface_id, uint16_t seconds_update)
     }
 
     protocol_interface_info_entry_t *interface = protocol_stack_interface_info_get_by_id(interface_id);
-    if (!interface) {
-        return;
-    }
-
-
-    if (!mac_neighbor_info(interface)) {
+    if (!interface || !mac_neighbor_info(interface)) {
         return;
     }
 
diff --git a/source/Service_Libs/mac_neighbor_table/mac_neighbor_table.c b/source/Service_Libs/mac_neighbor_table/mac_neighbor_table.c
@@ -26,8 +26,6 @@
 #include "Core/include/ns_address_internal.h"
 #include "platform/topo_trace.h"
 
-#define TRACE_GROUP "mnei"
-
 mac_neighbor_table_t *mac_neighbor_table_create(uint8_t table_size, neighbor_entry_remove_notify *remove_cb, neighbor_entry_nud_notify *nud_cb, void *user_indentifier)
 {
     mac_neighbor_table_t *table_class = ns_dyn_mem_alloc(sizeof(mac_neighbor_table_t) + sizeof(mac_neighbor_table_entry_t) * table_size);
@@ -111,11 +109,9 @@ void mac_neighbor_table_neighbor_timeout_update(mac_neighbor_table_t *table_clas
             if (table_class->user_nud_notify_cb(cur, table_class->table_user_identifier)) {
                 table_class->active_nud_process++;
                 cur->nud_active = true;
-                //tr_debug("Nud started index %u : %"PRIu32" time ", cur->index, cur->lifetime);
             }
 
         } else {
-            tr_debug("Node index %u time out ", cur->index);
             neighbor_table_class_remove_entry(table_class, cur);
         }
     }
@@ -176,7 +172,6 @@ void mac_neighbor_table_neighbor_refresh(mac_neighbor_table_t *table_class, mac_
     neighbor_entry->lifetime = life_time;
     neighbor_entry->link_lifetime = life_time;
     if (neighbor_entry->nud_active) {
-        //tr_debug("Node index NUD response %u : %"PRIu32" time ", neighbor_entry->index, neighbor_entry->lifetime);
         neighbor_entry->nud_active = false;
         table_class->active_nud_process--;
     }

Original file line number	Diff line number	Diff line change
`@@ -148,7 +148,6 @@ uint8_t mac_indirect_data_req_handle(mac_pre_parsed_frame_t *buf, protocol_inter`
`148`	`148`
`149`	`149`	`/* If the Ack we sent for the Data Request didn't have frame pending set, we shouldn't transmit - child may have slept */`
`150`	`150`	`if (!buf->ack_pendinfg_status) {`
`151`		`- //tr_debug("Drop by pending");`
`152`	`151`	`if (mac_ptr->indirect_pd_data_request_queue) {`
`153`	`152`	`tr_error("Wrongly dropped");`
`154`	`153`	`}`
Original file line number	Diff line number	Diff line change
`@@ -235,7 +235,6 @@ void mcps_sap_data_req_handler_ext(protocol_interface_rf_mac_setup_s *rf_mac_set`
`235`	`235`
`236`	`236`	`if (!rf_mac_setup->macUpState \|\| rf_mac_setup->scan_active) {`
`237`	`237`	`status = MLME_TRX_OFF;`
`238`		`- tr_debug("Drop MAC tx packet when mac disabled");`
`239`	`238`	`goto verify_status;`
`240`	`239`	`}`
`241`	`240`
`@@ -616,11 +615,6 @@ static uint8_t mac_data_interface_decrypt_packet(mac_pre_parsed_frame_t *b, mlme`
`616`	`615`	`ccm_ptr.data_ptr = (mcps_mac_payload_pointer_get(b) + openPayloadLength);`
`617`	`616`	`ccm_ptr.data_len = b->mac_payload_length - openPayloadLength;`
`618`	`617`	`if (ccm_process_run(&ccm_ptr) != 0) {`
`619`		`- tr_warning("MIC Fail adata %s", trace_array(ccm_ptr.adata_ptr, ccm_ptr.adata_len));`
`620`		`- tr_warning("Nonce %s", trace_array(ccm_ptr.exp_nonce, 13));`
`621`		`- if (openPayloadLength) {`
`622`		`- tr_warning("%s", tr_array(ccm_ptr.data_ptr, ccm_ptr.data_len));`
`623`		`- }`
`624`	`618`	`return MLME_SECURITY_FAIL;`
`625`	`619`	`}`
`626`	`620`
`@@ -662,7 +656,6 @@ static void mcps_comm_status_indication_generate(uint8_t status, mac_pre_parsed_`
`662`	`656`	`static int8_t mac_data_interface_host_accept_data(mcps_data_ind_t data_ind, protocol_interface_rf_mac_setup_s rf_mac_setup)`
`663`	`657`	`{`
`664`	`658`	`if ((data_ind->DstAddrMode == MAC_ADDR_MODE_16_BIT) && (data_ind->DstAddr[0] == 0xff && data_ind->DstAddr[1] == 0xff)) {`
`665`		`- tr_debug("Drop Multicast packet");`
`666`	`659`	`return -1;`
`667`	`660`	`}`
`668`	`661`
`@@ -723,7 +716,6 @@ static int8_t mac_data_sap_rx_handler(mac_pre_parsed_frame_t *buf, protocol_inte`
`723`	`716`	`}`
`724`	`717`
`725`	`718`	`if (!mac_payload_information_elements_parse(buf)) {`
`726`		`- tr_debug("Drop by Paylod IE");`
`727`	`719`	`goto DROP_PACKET;`
`728`	`720`	`}`
`729`	`721`	`data_ind->msduLength = buf->mac_payload_length;`
`@@ -741,7 +733,6 @@ static int8_t mac_data_sap_rx_handler(mac_pre_parsed_frame_t *buf, protocol_inte`
`741`	`733`
`742`	`734`	`if (buf->fcf_dsn.frameVersion == MAC_FRAME_VERSION_2015) {`
`743`	`735`	`if (!rf_mac_setup->mac_extension_enabled) {`
`744`		`- tr_debug("No Ext reg");`
`745`	`736`	`goto DROP_PACKET;`
`746`	`737`	`}`
`747`	`738`	`mcps_data_ie_list_t ie_list;`
`@@ -903,7 +894,6 @@ static void mac_data_interface_parse_beacon(mac_pre_parsed_frame_t *buf, protoco`
`903`	`894`	`}`
`904`	`895`
`905`	`896`	`if (!mac_payload_information_elements_parse(buf)) {`
`906`		`- tr_debug("Drop by Paylod IE");`
`907`	`897`	`return;`
`908`	`898`	`}`
`909`	`899`
`@@ -924,7 +914,6 @@ static void mac_data_interface_parse_beacon(mac_pre_parsed_frame_t *buf, protoco`
`924`	`914`	`if (len < gts_field_length) {`
`925`	`915`	`return;`
`926`	`916`	`}`
`927`		`-// gts_info = ptr;`
`928`	`917`	`len -= gts_field_length;`
`929`	`918`	`ptr += gts_field_length;`
`930`	`919`	`}`
`@@ -979,7 +968,6 @@ static void mac_data_interface_frame_handler(mac_pre_parsed_frame_t *buf)`
`979`	`968`	`{`
`980`	`969`	`protocol_interface_rf_mac_setup_s *rf_mac_setup = buf->mac_class_ptr;`
`981`	`970`	`if (!rf_mac_setup) {`
`982`		`- tr_debug("Drop by no mac class");`
`983`	`971`	`mcps_sap_pre_parsed_frame_buffer_free(buf);`
`984`	`972`	`return;`
`985`	`973`	`}`
`@@ -1084,13 +1072,11 @@ static int8_t mac_ack_sap_rx_handler(mac_pre_parsed_frame_t *buf, protocol_inter`
`1084`	`1072`	`if (buf->fcf_dsn.securityEnabled) {`
`1085`	`1073`	`uint8_t status = mac_data_interface_decrypt_packet(buf, &key);`
`1086`	`1074`	`if (status != MLME_SUCCESS) {`
`1087`		`- tr_debug("ACK Decrypt fail");`
`1088`	`1075`	`return -1;`
`1089`	`1076`	`}`
`1090`	`1077`	`}`
`1091`	`1078`
`1092`	`1079`	`if (buf->mac_payload_length && !mac_payload_information_elements_parse(buf)) {`
`1093`		`- tr_debug("Drop ACK by Paylod IE");`
`1094`	`1080`	`return -1;`
`1095`	`1081`	`}`
`1096`	`1082`
Original file line number	Diff line number	Diff line change
`@@ -856,7 +856,6 @@ static void rpl_control_dao_trigger_request(rpl_instance_t *instance, rpl_dodag_`
`856`	`856`	`static buffer_t rpl_control_dio_handler(protocol_interface_info_entry_t cur, rpl_domain_t domain, buffer_t buf)`
`857`	`857`	`{`
`858`	`858`	`if (!rpl_control_options_well_formed_in_buffer(buf, 24)) {`
`859`		`- tr_error("DIO format");`
`860`	`859`	`malformed:`
`861`	`860`	`protocol_stats_update(STATS_RPL_MALFORMED_MESSAGE, 1);`
`862`	`861`	`return buffer_free(buf);`
`@@ -1268,7 +1267,6 @@ void rpl_control_transmit_dio(rpl_domain_t *domain, protocol_interface_info_entr`
`1268`	`1267`	`static buffer_t rpl_control_dis_handler(protocol_interface_info_entry_t cur, rpl_domain_t domain, buffer_t buf, bool multicast)`
`1269`	`1268`	`{`
`1270`	`1269`	`if (!rpl_control_options_well_formed_in_buffer(buf, 2)) {`
`1271`		`- tr_error("DIS format");`
`1272`	`1270`	`protocol_stats_update(STATS_RPL_MALFORMED_MESSAGE, 1);`
`1273`	`1271`	`return buffer_free(buf);`
`1274`	`1272`	`}`
`@@ -1396,7 +1394,6 @@ static buffer_t rpl_control_dao_ack_handler(protocol_interface_info_entry_t cu`
`1396`	`1394`
`1397`	`1395`	`if (buffer_data_length(buf) < 4) {`
`1398`	`1396`	`format_error:`
`1399`		`- tr_error("DAO-ACK format");`
`1400`	`1397`	`protocol_stats_update(STATS_RPL_MALFORMED_MESSAGE, 1);`
`1401`	`1398`	`return buffer_free(buf);`
`1402`	`1399`	`}`
`@@ -1480,7 +1477,6 @@ static buffer_t rpl_control_dao_handler(protocol_interface_info_entry_t cur, r`
`1480`	`1477`	`{`
`1481`	`1478`	`if (buffer_data_length(buf) < 4) {`
`1482`	`1479`	`format_error:`
`1483`		`- tr_error("DAO format");`
`1484`	`1480`	`protocol_stats_update(STATS_RPL_MALFORMED_MESSAGE, 1);`
`1485`	`1481`	`return buffer_free(buf);`
`1486`	`1482`	`}`
Original file line number	Diff line number	Diff line change
`@@ -389,7 +389,7 @@ void rpl_instance_dao_trigger(rpl_instance_t *instance, uint16_t delay)`
`389`	`389`	`}`
`390`	`390`	`if (instance->delay_dao_timer == 0 \|\| instance->delay_dao_timer > delay) {`
`391`	`391`	`instance->delay_dao_timer = delay;`
`392`		`- tr_debug("DAO trigger %" PRIu16, delay);`
	`392`	`+ //tr_debug("DAO trigger %" PRIu16, delay);`
`393`	`393`	`}`
`394`	`394`	`}`
`395`	`395`
Original file line number	Diff line number	Diff line change
`@@ -157,7 +157,7 @@ static bool etx_update_possible(etx_sample_storage_t storage, etx_storage_t en`
`157`	`157`	`}`
`158`	`158`	`}`
`159`	`159`
`160`		`- tr_debug("ETX update possible %u attempts, %u rx ack", storage->attempts_count, storage->received_acks);`
	`160`	`+ //tr_debug("ETX update possible %u attempts, %u rx ack", storage->attempts_count, storage->received_acks);`
`161`	`161`
`162`	`162`	`return true;`
`163`	`163`
`@@ -318,9 +318,6 @@ uint16_t etx_read(int8_t interface_id, addrtype_t addr_type, const uint8_t *addr`
`318`	`318`	`}`
`319`	`319`	`attribute_index = mac_neighbor->index;`
`320`	`320`
`321`		`-`
`322`		`- //tr_debug("Etx Read from atribute %u", attribute_index);`
`323`		`-`
`324`	`321`	`etx_storage_t *entry = etx_storage_entry_get(interface_id, attribute_index);`
`325`	`322`
`326`	`323`	`if (!entry) {`
`@@ -330,8 +327,6 @@ uint16_t etx_read(int8_t interface_id, addrtype_t addr_type, const uint8_t *addr`
`330`	`327`	`uint16_t etx = etx_current_calc(entry->etx, entry->accumulated_failures);`
`331`	`328`	`etx >>= 4;`
`332`	`329`
`333`		`- //tr_debug("Etx value %u", etx);`
`334`		`-`
`335`	`330`	`return etx;`
`336`	`331`	`}`
`337`	`332`
`@@ -632,7 +627,6 @@ void etx_max_update_set(uint16_t etx_max_update)`
`632`	`627`	`etx_storage_t *etx_storage_entry_get(int8_t interface_id, uint8_t attribute_index)`
`633`	`628`	`{`
`634`	`629`	`if (etx_info.interface_id != interface_id \|\| !etx_info.etx_storage_list \|\| attribute_index >= etx_info.ext_storage_list_size) {`
`635`		`- //tr_debug("Unknow ID or un initilized ETX %u", attribute_index);`
`636`	`630`	`return NULL;`
`637`	`631`	`}`
`638`	`632`
`@@ -804,12 +798,7 @@ void etx_cache_timer(int8_t interface_id, uint16_t seconds_update)`
`804`	`798`	`}`
`805`	`799`
`806`	`800`	`protocol_interface_info_entry_t *interface = protocol_stack_interface_info_get_by_id(interface_id);`
`807`		`- if (!interface) {`
`808`		`- return;`
`809`		`- }`
`810`		`-`
`811`		`-`
`812`		`- if (!mac_neighbor_info(interface)) {`
	`801`	`+ if (!interface \|\| !mac_neighbor_info(interface)) {`
`813`	`802`	`return;`
`814`	`803`	`}`
`815`	`804`
Original file line number	Diff line number	Diff line change
`@@ -26,8 +26,6 @@`
`26`	`26`	`#include "Core/include/ns_address_internal.h"`
`27`	`27`	`#include "platform/topo_trace.h"`
`28`	`28`
`29`		`-#define TRACE_GROUP "mnei"`
`30`		`-`
`31`	`29`	`mac_neighbor_table_t mac_neighbor_table_create(uint8_t table_size, neighbor_entry_remove_notify remove_cb, neighbor_entry_nud_notify nud_cb, void user_indentifier)`
`32`	`30`	`{`
`33`	`31`	`mac_neighbor_table_t table_class = ns_dyn_mem_alloc(sizeof(mac_neighbor_table_t) + sizeof(mac_neighbor_table_entry_t) table_size);`
`@@ -111,11 +109,9 @@ void mac_neighbor_table_neighbor_timeout_update(mac_neighbor_table_t *table_clas`
`111`	`109`	`if (table_class->user_nud_notify_cb(cur, table_class->table_user_identifier)) {`
`112`	`110`	`table_class->active_nud_process++;`
`113`	`111`	`cur->nud_active = true;`
`114`		`- //tr_debug("Nud started index %u : %"PRIu32" time ", cur->index, cur->lifetime);`
`115`	`112`	`}`
`116`	`113`
`117`	`114`	`} else {`
`118`		`- tr_debug("Node index %u time out ", cur->index);`
`119`	`115`	`neighbor_table_class_remove_entry(table_class, cur);`
`120`	`116`	`}`
`121`	`117`	`}`
`@@ -176,7 +172,6 @@ void mac_neighbor_table_neighbor_refresh(mac_neighbor_table_t *table_class, mac_`
`176`	`172`	`neighbor_entry->lifetime = life_time;`
`177`	`173`	`neighbor_entry->link_lifetime = life_time;`
`178`	`174`	`if (neighbor_entry->nud_active) {`
`179`		`- //tr_debug("Node index NUD response %u : %"PRIu32" time ", neighbor_entry->index, neighbor_entry->lifetime);`
`180`	`175`	`neighbor_entry->nud_active = false;`
`181`	`176`	`table_class->active_nud_process--;`
`182`	`177`	`}`