moved the utility function into the pal since it's only useful below pal

Author: paul-szczepanek-arm

features/FEATURE_BLE/ble/BLETypes.h

@@ -668,26 +668,6 @@ class phy_set_t {
         set_coded(phy_coded);
     }
 
-    /**
-     * Create an ALL_PHYS parameter used in LE Set PHY Command
-     * and LE Set Default PHY Command.
-     * @see BLUETOOTH SPECIFICATION Version 5.0 | Vol 2, Part E - 7.8.49
-     */
-    static uint8_t all_phys_value(
-        const phy_set_t& tx_phys,
-        const phy_set_t& rx_phys
-    ) {
-        /* if phy set is empty set corresponding all_phys bit to 1 */
-        uint8_t all_phys = 0;
-        if (tx_phys.value() == 0) {
-            all_phys |= 0x01;
-        }
-        if (rx_phys.value() == 0) {
-            all_phys |= 0x02;
-        }
-        return all_phys;
-    }
-
     /** Prefer 1M PHY. */
     void set_1m(bool enabled = true) {
         if (enabled) {

features/FEATURE_BLE/ble/pal/PalGap.h

@@ -802,6 +802,27 @@ struct Gap {
         }
     }
 
+public:
+    /**
+     * Create an ALL_PHYS parameter used in LE Set PHY Command
+     * and LE Set Default PHY Command.
+     * @see BLUETOOTH SPECIFICATION Version 5.0 | Vol 2, Part E - 7.8.49
+     */
+    static uint8_t create_all_phys_value(
+        const phy_set_t& tx_phys,
+        const phy_set_t& rx_phys
+    ) {
+        /* if phy set is empty set corresponding all_phys bit to 1 */
+        uint8_t all_phys = 0;
+        if (tx_phys.value() == 0) {
+            all_phys |= 0x01;
+        }
+        if (rx_phys.value() == 0) {
+            all_phys |= 0x02;
+        }
+        return all_phys;
+    }
+
 private:
     /**
      * Callback called when an event is emitted by the LE subsystem.

features/FEATURE_BLE/targets/TARGET_CORDIO/source/CordioPalGap.cpp

@@ -343,7 +343,7 @@ ble_error_t Gap::set_preferred_phys(
     const phy_set_t& rx_phys
 ) {
     DmSetDefaultPhy(
-        phy_set_t::all_phys_value(tx_phys, rx_phys),
+        create_all_phys_value(tx_phys, rx_phys),
         tx_phys.value(),
         rx_phys.value()
     );
@@ -368,7 +368,7 @@ ble_error_t Gap::set_phy(
 
     DmSetPhy(
         connection,
-        phy_set_t::all_phys_value(tx_phys, rx_phys),
+        create_all_phys_value(tx_phys, rx_phys),
         tx_phys.value(),
         rx_phys.value(),
         coded_symbol.value()