Cellular: adding unit tests for new class CellularContext and changed classes.

Author: Teppo Järvelin

UNITTESTS/features/cellular/framework/AT/at_cellularcontext/at_cellularcontexttest.cpp

@@ -14,22 +14,26 @@ set(unittest-includes ${unittest-includes}
 # Source files
 set(unittest-sources
   ../features/cellular/framework/AT/AT_CellularContext.cpp
+  ../features/cellular/framework/common/CellularUtil.cpp
 )
 
 # Test files
 set(unittest-test-sources
   features/cellular/framework/AT/at_cellularcontext/at_cellularcontexttest.cpp
   stubs/ATHandler_stub.cpp
   stubs/AT_CellularBase_stub.cpp
+  stubs/AT_CellularDevice_stub.cpp
+  stubs/AT_CellularStack_stub.cpp
+  stubs/AT_CellularNetwork_stub.cpp
+  stubs/CellularDevice_stub.cpp
+  stubs/CellularStateMachine_stub.cpp
+  stubs/equeue_stub.c
   stubs/EventQueue_stub.cpp
   stubs/FileHandle_stub.cpp
+  stubs/mbed_assert_stub.c
   stubs/NetworkInterface_stub.cpp
   stubs/NetworkStack_stub.cpp
-  stubs/us_ticker_stub.cpp
-  stubs/mbed_assert_stub.c
-  stubs/CellularDevice_stub.cpp
-  stubs/CellularStateMachine_stub.cpp
+  stubs/randLIB_stub.cpp
   stubs/Semaphore_stub.cpp
-  stubs/CellularUtil_stub.cpp
-  stubs/equeue_stub.c
+  stubs/us_ticker_stub.cpp
 )

UNITTESTS/features/cellular/framework/AT/at_cellularcontext/unittest.cmake

@@ -15,10 +15,10 @@
  * limitations under the License.
  */
 #include "gtest/gtest.h"
+#include <string.h>
 #include "AT_CellularDevice.h"
 #include "ATHandler_stub.h"
 #include "AT_CellularBase_stub.h"
-#include <string.h>
 
 using namespace mbed;
 using namespace events;
@@ -270,3 +270,40 @@ TEST_F(TestAT_CellularDevice, test_AT_CellularDevice_init_module)
     AT_CellularDevice dev(&fh1);
     EXPECT_TRUE(NSAPI_ERROR_OK == dev.init_module());
 }
+
+TEST_F(TestAT_CellularDevice, test_AT_CellularDevice_create_delete_context)
+{
+    FileHandle_stub fh1;
+    AT_CellularDevice *dev = new AT_CellularDevice(&fh1);
+
+    CellularContext *ctx = dev->create_context(NULL);
+    delete dev;
+
+    dev = new AT_CellularDevice(&fh1);
+    ctx = dev->create_context(NULL);
+    CellularContext *ctx1 = dev->create_context(&fh1);
+    CellularContext *ctx2 = dev->create_context(&fh1);
+
+    EXPECT_TRUE(ctx);
+    EXPECT_TRUE(ctx1);
+    EXPECT_TRUE(ctx1 != ctx);
+    EXPECT_TRUE(ctx1 != ctx2);
+
+    CellularContext *xx = dev->get_context_list();
+    EXPECT_TRUE(xx);
+
+    dev->delete_context(ctx);
+    dev->delete_context(ctx1);
+    dev->delete_context(NULL);
+    dev->delete_context(ctx2);
+
+    ctx = dev->create_context(NULL);
+    ctx1 = dev->create_context(&fh1);
+    ctx2 = dev->create_context(&fh1);
+    EXPECT_TRUE(ctx);
+    EXPECT_TRUE(ctx1);
+    EXPECT_TRUE(ctx1 != ctx);
+    EXPECT_TRUE(ctx1 != ctx2);
+
+    delete dev;
+}

UNITTESTS/features/cellular/framework/AT/at_cellulardevice/at_cellulardevicetest.cpp

@@ -5,7 +5,7 @@
 
 # Add test specific include paths
 set(unittest-includes ${unittest-includes}
-  features/cellular/framework/common/util
+  ../features/cellular/framework/common/util
   ../features/cellular/framework/common
   ../features/cellular/framework/AT
   ../features/cellular/framework/device

UNITTESTS/features/cellular/framework/AT/at_cellulardevice/unittest.cmake

@@ -0,0 +1,231 @@
+/*
+ * Copyright (c) 2018, Arm Limited and affiliates.
+ * SPDX-License-Identifier: Apache-2.0
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#include "gtest/gtest.h"
+#include <string.h>
+
+#include "CellularDevice.h"
+#include "FileHandle_stub.h"
+#include "myCellularDevice.h"
+#include "CellularStateMachine_stub.h"
+#include "CellularSIM.h"
+
+using namespace mbed;
+
+// AStyle ignored as the definition is not clear due to preprocessor usage
+// *INDENT-OFF*
+class TestCellularDevice : public testing::Test {
+protected:
+
+    void SetUp()
+    {
+        CellularStateMachine_stub::nsapi_error_value = NSAPI_ERROR_OK;
+        CellularStateMachine_stub::get_current_target_state = STATE_INIT;
+        CellularStateMachine_stub::get_current_current_state = STATE_INIT;
+        CellularStateMachine_stub::bool_value = false;
+    }
+
+    void TearDown()
+    {
+    }
+};
+
+// *INDENT-ON*
+TEST_F(TestCellularDevice, test_create_delete)
+{
+    FileHandle_stub fh1;
+
+    CellularDevice *dev = new myCellularDevice(&fh1);
+    EXPECT_TRUE(dev);
+    delete dev;
+    dev = NULL;
+
+    CellularDevice *dev1 = CellularDevice::get_default_instance();
+    EXPECT_TRUE(dev1);
+}
+
+TEST_F(TestCellularDevice, test_set_sim_pin)
+{
+    FileHandle_stub fh1;
+    CellularDevice *dev = new myCellularDevice(&fh1);
+    EXPECT_TRUE(dev);
+
+    // MAX_PIN_SIZE = 8; so let's try a longer one
+    dev->set_sim_pin("123480375462074360276407");
+    dev->set_sim_pin(NULL);
+    dev->set_sim_pin("1234");
+    delete dev;
+}
+
+TEST_F(TestCellularDevice, test_set_plmn)
+{
+    FileHandle_stub fh1;
+    CellularDevice *dev = new myCellularDevice(&fh1);
+    EXPECT_TRUE(dev);
+
+
+    // MAX_PLMN_SIZE = 16; so let's try a longer one
+    dev->set_plmn("123480327465023746502734602736073264076340");
+    dev->set_plmn("1234");
+    dev->set_plmn(NULL);
+    delete dev;
+}
+
+TEST_F(TestCellularDevice, test_set_device_ready)
+{
+    FileHandle_stub fh1;
+    CellularDevice *dev = new myCellularDevice(&fh1);
+    EXPECT_TRUE(dev);
+
+    CellularStateMachine_stub::nsapi_error_value = NSAPI_ERROR_NO_MEMORY;
+    ASSERT_EQ(dev->set_device_ready(), NSAPI_ERROR_NO_MEMORY);
+
+    CellularStateMachine_stub::nsapi_error_value = NSAPI_ERROR_OK;
+    ASSERT_EQ(dev->set_device_ready(), NSAPI_ERROR_OK);
+
+    CellularStateMachine_stub::get_current_current_state = STATE_SIM_PIN;
+    CellularStateMachine_stub::nsapi_error_value = NSAPI_ERROR_OK;
+    ASSERT_EQ(dev->set_device_ready(), NSAPI_ERROR_ALREADY);
+
+    CellularStateMachine_stub::bool_value = true;
+    CellularStateMachine_stub::get_current_target_state = STATE_SIM_PIN;
+    CellularStateMachine_stub::get_current_current_state = STATE_POWER_ON;
+    ASSERT_EQ(dev->set_device_ready(), NSAPI_ERROR_IN_PROGRESS);
+    delete dev;
+}
+
+TEST_F(TestCellularDevice, test_set_sim_ready)
+{
+    FileHandle_stub fh1;
+    CellularDevice *dev = new myCellularDevice(&fh1);
+    EXPECT_TRUE(dev);
+
+    CellularStateMachine_stub::nsapi_error_value = NSAPI_ERROR_NO_MEMORY;
+    ASSERT_EQ(dev->set_sim_ready(), NSAPI_ERROR_NO_MEMORY);
+
+    CellularStateMachine_stub::nsapi_error_value = NSAPI_ERROR_OK;
+    ASSERT_EQ(dev->set_sim_ready(), NSAPI_ERROR_OK);
+
+    CellularStateMachine_stub::get_current_current_state = STATE_MANUAL_REGISTERING_NETWORK;
+    CellularStateMachine_stub::nsapi_error_value = NSAPI_ERROR_OK;
+    ASSERT_EQ(dev->set_sim_ready(), NSAPI_ERROR_ALREADY);
+
+    CellularStateMachine_stub::bool_value = true;
+    CellularStateMachine_stub::get_current_target_state = STATE_MANUAL_REGISTERING_NETWORK;
+    CellularStateMachine_stub::get_current_current_state = STATE_POWER_ON;
+    ASSERT_EQ(dev->set_sim_ready(), NSAPI_ERROR_IN_PROGRESS);
+    delete dev;
+}
+
+TEST_F(TestCellularDevice, test_register_to_network)
+{
+    FileHandle_stub fh1;
+    CellularDevice *dev = new myCellularDevice(&fh1);
+    EXPECT_TRUE(dev);
+
+    CellularStateMachine_stub::nsapi_error_value = NSAPI_ERROR_NO_MEMORY;
+    ASSERT_EQ(dev->register_to_network(), NSAPI_ERROR_NO_MEMORY);
+
+    CellularStateMachine_stub::nsapi_error_value = NSAPI_ERROR_OK;
+    ASSERT_EQ(dev->register_to_network(), NSAPI_ERROR_OK);
+
+    CellularStateMachine_stub::get_current_current_state = STATE_ATTACHING_NETWORK;
+    CellularStateMachine_stub::nsapi_error_value = NSAPI_ERROR_OK;
+    ASSERT_EQ(dev->register_to_network(), NSAPI_ERROR_ALREADY);
+
+    CellularStateMachine_stub::bool_value = true;
+    CellularStateMachine_stub::get_current_target_state = STATE_ATTACHING_NETWORK;
+    CellularStateMachine_stub::get_current_current_state = STATE_POWER_ON;
+    ASSERT_EQ(dev->register_to_network(), NSAPI_ERROR_IN_PROGRESS);
+    delete dev;
+}
+
+TEST_F(TestCellularDevice, test_attach_to_network)
+{
+    FileHandle_stub fh1;
+    CellularDevice *dev = new myCellularDevice(&fh1);
+    EXPECT_TRUE(dev);
+
+    CellularStateMachine_stub::nsapi_error_value = NSAPI_ERROR_NO_MEMORY;
+    ASSERT_EQ(dev->attach_to_network(), NSAPI_ERROR_NO_MEMORY);
+
+    CellularStateMachine_stub::nsapi_error_value = NSAPI_ERROR_OK;
+    ASSERT_EQ(dev->attach_to_network(), NSAPI_ERROR_OK);
+
+    CellularStateMachine_stub::get_current_current_state = STATE_ATTACHING_NETWORK;
+    CellularStateMachine_stub::nsapi_error_value = NSAPI_ERROR_OK;
+    ASSERT_EQ(dev->attach_to_network(), NSAPI_ERROR_ALREADY);
+
+    CellularStateMachine_stub::bool_value = true;
+    CellularStateMachine_stub::get_current_target_state = STATE_ATTACHING_NETWORK;
+    CellularStateMachine_stub::get_current_current_state = STATE_POWER_ON;
+    ASSERT_EQ(dev->attach_to_network(), NSAPI_ERROR_IN_PROGRESS);
+    delete dev;
+}
+
+TEST_F(TestCellularDevice, test_get_context_list)
+{
+    FileHandle_stub fh1;
+
+    CellularDevice *dev = new myCellularDevice(&fh1);
+    EXPECT_TRUE(dev);
+    CellularContext *ctx = dev->create_context();
+    EXPECT_TRUE(dev->get_context_list());
+    delete dev;
+    dev = NULL;
+
+    dev = new myCellularDevice(&fh1);
+    EXPECT_TRUE(dev);
+    EXPECT_FALSE(dev->get_context_list());
+}
+
+TEST_F(TestCellularDevice, test_stop)
+{
+    FileHandle_stub fh1;
+    CellularDevice *dev = new myCellularDevice(&fh1);
+    EXPECT_TRUE(dev);
+
+    CellularStateMachine_stub::nsapi_error_value = NSAPI_ERROR_OK;
+    ASSERT_EQ(dev->attach_to_network(), NSAPI_ERROR_OK);
+
+    dev->stop();
+    delete dev;
+}
+
+TEST_F(TestCellularDevice, test_cellular_callback)
+{
+    FileHandle_stub fh1;
+    myCellularDevice *dev = new myCellularDevice(&fh1);
+    EXPECT_TRUE(dev);
+
+    ASSERT_EQ(dev->attach_to_network(), NSAPI_ERROR_OK);
+
+    cell_callback_data_t data;
+    dev->cellular_callback((nsapi_event_t)CellularRegistrationStatusChanged, (intptr_t)&data);
+
+    data.error = NSAPI_ERROR_OK;
+    dev->set_plmn("1234");
+    dev->cellular_callback((nsapi_event_t)CellularDeviceReady, (intptr_t)&data);
+
+    dev->set_sim_pin("1234");
+    data.status_data = CellularSIM::SimStatePinNeeded;
+    dev->cellular_callback((nsapi_event_t)CellularSIMStatusChanged, (intptr_t)&data);
+
+    CellularContext *ctx = dev->create_context();
+    dev->cellular_callback(NSAPI_EVENT_CONNECTION_STATUS_CHANGE, NSAPI_STATUS_DISCONNECTED);
+
+    delete dev;
+}

UNITTESTS/features/cellular/framework/device/cellulardevice/cellulardevicetest.cpp

@@ -0,0 +1,37 @@
+
+####################
+# UNIT TESTS
+####################
+
+# Add test specific include paths
+set(unittest-includes ${unittest-includes}
+    /features/cellular/framework/device/cellulardevice
+  ../features/cellular/framework/device
+  ../features/cellular/framework/common
+)
+
+# Source files
+set(unittest-sources
+  ../features/cellular/framework/device/CellularDevice.cpp
+)
+
+# Test files
+set(unittest-test-sources
+  features/cellular/framework/device/cellulardevice/cellulardevicetest.cpp
+  stubs/FileHandle_stub.cpp
+  stubs/CellularStateMachine_stub.cpp
+  stubs/EventQueue_stub.cpp
+  stubs/mbed_assert_stub.c
+  stubs/UARTSerial_stub.cpp
+  stubs/SerialBase_stub.cpp
+  stubs/ATHandler_stub.cpp
+  stubs/AT_CellularNetwork_stub.cpp
+  stubs/AT_CellularBase_stub.cpp
+  stubs/AT_CellularContext_stub.cpp
+  stubs/Semaphore_stub.cpp
+  stubs/NetworkInterface_stub.cpp
+)
+
+# defines
+set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -DMDMRTS=PTC0 -DMDMCTS=PTC1 -DMDMTXD=NC -DMDMRXD=NC -DMBED_CONF_PLATFORM_DEFAULT_SERIAL_BAUD_RATE=115200 -DCELLULAR_DEVICE=myCellularDevice -DDEVICE_SERIAL_FC=1")
+set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -DMDMRTS=PTC0 -DMDMCTS=PTC1 -DMDMTXD=NC -DMDMRXD=NC -DMBED_CONF_PLATFORM_DEFAULT_SERIAL_BAUD_RATE=115200 -DCELLULAR_DEVICE=myCellularDevice -DDEVICE_SERIAL_FC=1")

UNITTESTS/features/cellular/framework/device/cellulardevice/unittest.cmake

@@ -170,6 +170,7 @@ ssize_t ATHandler::read_string(char *buf, size_t size, bool read_even_stop_tag)
     if (ATHandler_stub::read_string_index == kRead_string_table_size) {
         if (ATHandler_stub::read_string_value && ATHandler_stub::ssize_value >= 0) {
             memcpy(buf, ATHandler_stub::read_string_value, ATHandler_stub::ssize_value + 1);
+            buf[ATHandler_stub::ssize_value] = '\0';
         }
         return ATHandler_stub::ssize_value;
     }
@@ -179,6 +180,7 @@ ssize_t ATHandler::read_string(char *buf, size_t size, bool read_even_stop_tag)
         const char *tmp = ATHandler_stub::read_string_table[ATHandler_stub::read_string_index];
         ssize_t len = strlen(tmp);
         memcpy(buf, tmp, len + 1);
+        buf[len] = '\0';
         return len;
     }