Skip to content

Commit e9eb32b

Browse files
author
Kimmo Vaisanen
committed
Lora: Fix max tx power check
In LoRa TX power value 0 means the maximum allowed TX power and values >0 are limiting the allowed TX power to lower. tx_config was incorrectly checking the power level and causing the maximum TX power to be always used. Lora gateway can request node to use lower TX power with LinkAdrReq MAC command.
1 parent 2e4966a commit e9eb32b

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

features/lorawan/lorastack/phy/LoRaPHY.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -880,9 +880,7 @@ bool LoRaPHY::tx_config(tx_config_params_t* tx_conf, int8_t* tx_power,
880880
band_t *bands = (band_t *)phy_params.bands.table;
881881

882882
// limit TX power if set to too much
883-
if (tx_conf->tx_power > bands[band_idx].max_tx_pwr) {
884-
tx_conf->tx_power = bands[band_idx].max_tx_pwr;
885-
}
883+
tx_conf->tx_power = MAX(tx_conf->tx_power, bands[band_idx].max_tx_pwr);
886884

887885
uint8_t bandwidth = get_bandwidth(tx_conf->datarate);
888886
int8_t phy_tx_power = 0;

0 commit comments

Comments
 (0)