Skip to content

Commit f8e18cd

Browse files
committed
Change TimMasterHandle variable declaration + typo corrections
1 parent cc24e5b commit f8e18cd

File tree

4 files changed

+24
-35
lines changed

4 files changed

+24
-35
lines changed

targets/TARGET_STM/hal_tick_16b.c

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -32,18 +32,19 @@
3232

3333
#define DEBUG_TICK 0 // Set to 1 to toggle a pin (see below which pin) at each tick
3434

35-
TIM_HandleTypeDef TimMasterHandle;
36-
volatile uint32_t PreviousVal = 0;
37-
38-
void us_ticker_irq_handler(void);
39-
void set_compare(uint16_t count);
35+
extern TIM_HandleTypeDef TimMasterHandle;
4036

4137
extern volatile uint32_t SlaveCounter;
4238
extern volatile uint32_t oc_int_part;
4339
extern volatile uint16_t oc_rem_part;
4440
extern volatile uint8_t tim_it_update;
4541
extern volatile uint32_t tim_it_counter;
4642

43+
volatile uint32_t PreviousVal = 0;
44+
45+
void us_ticker_irq_handler(void);
46+
void set_compare(uint16_t count);
47+
4748
#if defined(TARGET_STM32F0)
4849
void timer_update_irq_handler(void) {
4950
#else
@@ -65,8 +66,7 @@ void timer_irq_handler(void) {
6566
#if defined(TARGET_STM32F0)
6667
} // end timer_update_irq_handler function
6768
// Used for mbed timeout (channel 1) and HAL tick (channel 2)
68-
void timer_oc_irq_handler(void)
69-
{
69+
void timer_oc_irq_handler(void) {
7070
uint16_t cnt_val = TIM_MST->CNT;
7171
TimMasterHandle.Instance = TIM_MST;
7272
#endif
@@ -173,18 +173,14 @@ HAL_StatusTypeDef HAL_InitTick(uint32_t TickPriority) {
173173
return HAL_OK;
174174
}
175175

176-
void HAL_SuspendTick(void)
177-
{
176+
void HAL_SuspendTick(void) {
178177
TimMasterHandle.Instance = TIM_MST;
179-
180178
// Disable HAL tick and us_ticker update interrupts (used for 32 bit counter)
181179
__HAL_TIM_DISABLE_IT(&TimMasterHandle, (TIM_IT_CC2 | TIM_IT_UPDATE));
182180
}
183181

184-
void HAL_ResumeTick(void)
185-
{
182+
void HAL_ResumeTick(void) {
186183
TimMasterHandle.Instance = TIM_MST;
187-
188184
// Enable HAL tick and us_ticker update interrupts (used for 32 bit counter)
189185
__HAL_TIM_ENABLE_IT(&TimMasterHandle, (TIM_IT_CC2 | TIM_IT_UPDATE));
190186
}

targets/TARGET_STM/hal_tick_32b.c

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,8 @@
3232

3333
#define DEBUG_TICK 0 // Set to 1 to toggle a pin (see below which pin) at each tick
3434

35-
TIM_HandleTypeDef TimMasterHandle;
35+
extern TIM_HandleTypeDef TimMasterHandle;
36+
3637
volatile uint32_t PreviousVal = 0;
3738

3839
void us_ticker_irq_handler(void);
@@ -136,18 +137,14 @@ HAL_StatusTypeDef HAL_InitTick(uint32_t TickPriority) {
136137
return HAL_OK;
137138
}
138139

139-
void HAL_SuspendTick(void)
140-
{
140+
void HAL_SuspendTick(void) {
141141
TimMasterHandle.Instance = TIM_MST;
142-
143142
// Disable HAL tick and us_ticker update interrupts (used for 32 bit counter)
144143
__HAL_TIM_DISABLE_IT(&TimMasterHandle, (TIM_IT_CC2 | TIM_IT_UPDATE));
145144
}
146145

147-
void HAL_ResumeTick(void)
148-
{
146+
void HAL_ResumeTick(void) {
149147
TimMasterHandle.Instance = TIM_MST;
150-
151148
// Enable HAL tick and us_ticker update interrupts (used for 32 bit counter)
152149
__HAL_TIM_ENABLE_IT(&TimMasterHandle, (TIM_IT_CC2 | TIM_IT_UPDATE));
153150
}

targets/TARGET_STM/us_ticker_16b.c

Lines changed: 9 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -33,26 +33,25 @@
3333
// A 16-bit timer is used
3434
#if TIM_MST_16BIT
3535

36-
static TIM_HandleTypeDef TimMasterHandle;
37-
static int us_ticker_inited = 0;
36+
TIM_HandleTypeDef TimMasterHandle;
3837

3938
volatile uint32_t SlaveCounter = 0;
4039
volatile uint32_t oc_int_part = 0;
4140
volatile uint16_t oc_rem_part = 0;
4241
volatile uint8_t tim_it_update; // TIM_IT_UPDATE event flag set in timer_irq_handler()
4342
volatile uint32_t tim_it_counter = 0; // Time stamp to be updated by timer_irq_handler()
4443

45-
void set_compare(uint16_t count)
46-
{
44+
static int us_ticker_inited = 0;
45+
46+
void set_compare(uint16_t count) {
4747
TimMasterHandle.Instance = TIM_MST;
4848
// Set new output compare value
4949
__HAL_TIM_SetCompare(&TimMasterHandle, TIM_CHANNEL_1, count);
5050
// Enable IT
5151
__HAL_TIM_ENABLE_IT(&TimMasterHandle, TIM_IT_CC1);
5252
}
5353

54-
void us_ticker_init(void)
55-
{
54+
void us_ticker_init(void) {
5655
if (us_ticker_inited) return;
5756
us_ticker_inited = 1;
5857

@@ -61,8 +60,7 @@ void us_ticker_init(void)
6160
HAL_InitTick(0); // The passed value is not used
6261
}
6362

64-
uint32_t us_ticker_read()
65-
{
63+
uint32_t us_ticker_read() {
6664
uint32_t counter;
6765

6866
TimMasterHandle.Instance = TIM_MST;
@@ -106,8 +104,7 @@ uint32_t us_ticker_read()
106104
}
107105
}
108106

109-
void us_ticker_set_interrupt(timestamp_t timestamp)
110-
{
107+
void us_ticker_set_interrupt(timestamp_t timestamp) {
111108
int delta = (int)((uint32_t)timestamp - us_ticker_read());
112109

113110
uint16_t cval = TIM_MST->CNT;
@@ -127,14 +124,12 @@ void us_ticker_set_interrupt(timestamp_t timestamp)
127124
}
128125
}
129126

130-
void us_ticker_disable_interrupt(void)
131-
{
127+
void us_ticker_disable_interrupt(void) {
132128
TimMasterHandle.Instance = TIM_MST;
133129
__HAL_TIM_DISABLE_IT(&TimMasterHandle, TIM_IT_CC1);
134130
}
135131

136-
void us_ticker_clear_interrupt(void)
137-
{
132+
void us_ticker_clear_interrupt(void) {
138133
TimMasterHandle.Instance = TIM_MST;
139134
if (__HAL_TIM_GET_FLAG(&TimMasterHandle, TIM_FLAG_CC1) == SET) {
140135
__HAL_TIM_CLEAR_FLAG(&TimMasterHandle, TIM_FLAG_CC1);

targets/TARGET_STM/us_ticker_32b.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,8 @@
3333
// A 32-bit timer is used
3434
#if !TIM_MST_16BIT
3535

36-
static TIM_HandleTypeDef TimMasterHandle;
36+
TIM_HandleTypeDef TimMasterHandle;
37+
3738
static int us_ticker_inited = 0;
3839

3940
void us_ticker_init(void) {

0 commit comments

Comments
 (0)