Skip to content

Commit ff817de

Browse files
committed
Fix broken cellular_device test and delete commented code
1 parent 97d6a91 commit ff817de

File tree

3 files changed

+6
-32
lines changed

3 files changed

+6
-32
lines changed

features/cellular/framework/targets/MultiTech/DragonflyNano/PPP/SARA4_PPP.cpp

Lines changed: 4 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -37,31 +37,13 @@ SARA4_PPP::~SARA4_PPP()
3737
{
3838
}
3939

40-
CellularNetwork *SARA4_PPP::open_network(FileHandle *fh)
40+
AT_CellularNetwork *SARA4_PPP::open_network_impl(ATHandler &at)
4141
{
42-
if (!_network) {
43-
ATHandler *atHandler = get_at_handler(fh);
44-
if (atHandler) {
45-
_network = new SARA4_PPP_CellularNetwork(*atHandler);
46-
if (!_network) {
47-
release_at_handler(atHandler);
48-
}
49-
}
50-
}
51-
return _network;
42+
return new SARA4_PPP_CellularNetwork(at);
5243
}
5344

54-
CellularPower *SARA4_PPP::open_power(FileHandle *fh)
45+
AT_CellularPower *SARA4_PPP::open_power_impl(ATHandler &at)
5546
{
56-
if (!_power) {
57-
ATHandler *atHandler = get_at_handler(fh);
58-
if (atHandler) {
59-
_power = new SARA4_PPP_CellularPower(*atHandler);
60-
if (!_power) {
61-
release_at_handler(atHandler);
62-
}
63-
}
64-
}
65-
return _power;
47+
return new SARA4_PPP_CellularPower(at);
6648
}
6749

features/cellular/framework/targets/MultiTech/DragonflyNano/PPP/SARA4_PPP.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ class SARA4_PPP : public AT_CellularDevice {
2929
virtual ~SARA4_PPP();
3030

3131
public: // CellularDevice
32-
virtual CellularNetwork *open_network(FileHandle *fh);
33-
virtual CellularPower *open_power(FileHandle *fh);
32+
virtual AT_CellularNetwork *open_network_impl(ATHandler &at);
33+
virtual AT_CellularPower *open_power_impl(ATHandler &at);
3434
};
3535

3636
} // namespace mbed

features/cellular/framework/targets/MultiTech/DragonflyNano/PPP/SARA4_PPP_CellularNetwork.cpp

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -34,15 +34,7 @@ bool SARA4_PPP_CellularNetwork::get_modem_stack_type(nsapi_ip_stack_t requested_
3434

3535
AT_CellularNetwork::RegistrationMode SARA4_PPP_CellularNetwork::has_registration(RegistrationType reg_type)
3636
{
37-
//<<<<<<< HEAD
3837
return (reg_type == C_REG || reg_type == C_GREG) ? RegistrationModeLAC : RegistrationModeDisable;
39-
//=======
40-
//#ifdef TARGET_DRAGONFLY_L471QG
41-
// return (reg_type == C_REG || reg_type == C_EREG);
42-
//#else
43-
// return (reg_type == C_REG || reg_type == C_GREG || reg_type == C_EREG);
44-
//#endif
45-
//>>>>>>> Fixed spacing/tabs and clean up targets.json
4638
}
4739

4840
nsapi_error_t SARA4_PPP_CellularNetwork::set_access_technology_impl(RadioAccessTechnology opRat)

0 commit comments

Comments
 (0)