Skip to content

usb_device-msd test: fix powershell unmount script issue #10767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 28, 2019
Merged

usb_device-msd test: fix powershell unmount script issue #10767

merged 6 commits into from
Jun 28, 2019

Conversation

maciejbocianski
Copy link
Contributor

@maciejbocianski maciejbocianski commented Jun 5, 2019 •
edited
Loading

Description

  • Fix for the mass storage unmount procedure on Windows machines for usb_device-msd test.
    Running PowerShell script on some windows machines is blocked. To avoid this problem unmount script was replace by the code run directly in PowerShell console.
  • Improve error handling.
  • Encountering further problems with disk unmount on windows machines, drove the decision to disable host side unmount on windows machines to make the test more stable.
  • Update test documentation

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@fkjagodzinski

Release Notes

@ciarmcom ciarmcom requested review from fkjagodzinski and a team June 5, 2019 17:00
@ciarmcom
Copy link
Member

ciarmcom commented Jun 5, 2019

@maciejbocianski, thank you for your changes.
@fkjagodzinski @ARMmbed/mbed-os-maintainers please review.

fkjagodzinski
fkjagodzinski reviewed Jun 17, 2019
View reviewed changes
@maciejbocianski
usb_device-msd test: fix powershell unmount script issue
1828516 
Running PowerShell script on some windows machines is blocked.
To avoid this problem script was replace by the code run directly in PowerShell console.
@maciejbocianski
usb_device-msd test: improve error handling
f6d6863
@maciejbocianski
usb_device-msd test: disable host side unmount on windows machines
4378c14
@maciejbocianski
usb_device-msd test: docs update
855a6dd
@maciejbocianski maciejbocianski force-pushed the msd_test_windows_unmount_fix branch from 02e7e5e to 855a6dd Compare June 19, 2019 13:11
@maciejbocianski maciejbocianski mentioned this pull request Jun 25, 2019
Closed
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 27, 2019

Ci started

@mbed-ci
Copy link

mbed-ci commented Jun 27, 2019

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit dfdf70b into ARMmbed:master Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@fkjagodzinski fkjagodzinski fkjagodzinski approved these changes

Assignees
No one assigned
Labels
release-version: 5.13.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@maciejbocianski @ciarmcom @0xc0170 @mbed-ci @fkjagodzinski @adbridge