-
Notifications
You must be signed in to change notification settings - Fork 3k
PSOC6: USB device implementation #11071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@cypress-neil, thank you for your changes. |
@ARMmbed/team-cypress please review. Also @cypress-neil could you upload the test results for the usb subsystem please. |
@ARMmbed/mbed-os-hal Please review the proposed API. This |
Test run: FAILEDSummary: 3 of 4 test jobs failed Failed test jobs:
|
Build failures:
|
@cypress-neil , it appears that targets.json enables USB Device for PSoC6 and FUTURE_SEQUANA what is not correct. The FUTURE_SEQUANA target must be updated because it does not support USB. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@SeppoTakalo, this is fine, and actually follows our template (same as other tartgets) https://github.com/ARMmbed/mbed-os/blob/master/usb/device/targets/TARGET_Template/USBPhyHw.h |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Description
This PR adds the PSOC6 USB files which were separated from #10692 (see #10692 (comment) ).
Pull request type
Reviewers
@ARMmbed/team-cypress
Release Notes