Skip to content

PSOC6: USB device implementation #11071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2019
Merged

Conversation

cypress-neil
Copy link
Contributor

Description

This PR adds the PSOC6 USB files which were separated from #10692 (see #10692 (comment) ).

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ARMmbed/team-cypress

Release Notes

@ciarmcom
Copy link
Member

@cypress-neil, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team July 18, 2019 21:00
@cypress-neil cypress-neil marked this pull request as ready for review July 19, 2019 17:09
@bulislaw
Copy link
Member

@ARMmbed/team-cypress please review. Also @cypress-neil could you upload the test results for the usb subsystem please.

@SeppoTakalo SeppoTakalo requested a review from a team July 22, 2019 12:01
@SeppoTakalo SeppoTakalo requested a review from a team July 23, 2019 09:13
@SeppoTakalo
Copy link
Contributor

@ARMmbed/mbed-os-hal Please review the proposed API. This USBPhyHw is quite generic name, but only provided by this one platform. Review if this is OK. Thanks.

@mbed-ci
Copy link

mbed-ci commented Jul 23, 2019

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARM

@SeppoTakalo
Copy link
Contributor

Build failures:

[2019-07-23T11:07:09.576Z] [2019-07-23T11:07:09.576Z] + tail -n 100 mbed-os-greentea_FUTURE_SEQUANA_ARM.log

[2019-07-23T11:07:09.576Z] [2019-07-23T11:07:09.576Z]         Building project hid (FUTURE_SEQUANA, ARMC6)

[2019-07-23T11:07:09.576Z] [2019-07-23T11:07:09.576Z]         Scan: ARM

[2019-07-23T11:07:09.576Z] [2019-07-23T11:07:09.576Z]         Scan: hid

[2019-07-23T11:07:09.576Z] [2019-07-23T11:07:09.576Z]         Compile [100.0%]: main.cpp

[2019-07-23T11:07:09.576Z] [2019-07-23T11:07:09.576Z]         [Warning] main.cpp@41,9: 'MSG_KEY_DEVICE_READY' macro redefined [-Wmacro-redefined]

[2019-07-23T11:07:09.576Z] [2019-07-23T11:07:09.576Z]         Link: hid

[2019-07-23T11:07:09.576Z] [2019-07-23T11:07:09.576Z]         [Warning] @0,0: L3912W: Option 'legacyalign' is deprecated.

[2019-07-23T11:07:09.576Z] [2019-07-23T11:07:09.576Z]         [Warning] @0,0: L9931W: Your license for feature compiler5 will expire in 8 days

[2019-07-23T11:07:09.576Z] [2019-07-23T11:07:09.576Z]         [Warning] @0,0: L9931W: Your license for feature compiler5 will expire in 8 days

[2019-07-23T11:07:09.576Z] [2019-07-23T11:07:09.576Z]         [Error] @0,0: L6218E: Undefined symbol get_usb_phy() (referred from BUILD/tests/FUTURE_SEQUANA/ARM/TESTS/usb_device/hid/TESTS/usb_device/hid/main.o).

[2019-07-23T11:07:09.576Z] [2019-07-23T11:07:09.576Z]         Warning: L3912W: Option 'legacyalign' is deprecated.

[2019-07-23T11:07:09.576Z] [2019-07-23T11:07:09.576Z]         Warning: L9931W: Your license for feature compiler5 will expire in 8 days

[2019-07-23T11:07:09.576Z] [2019-07-23T11:07:09.576Z]         Warning: L9931W: Your license for feature compiler5 will expire in 8 days

[2019-07-23T11:07:09.576Z] [2019-07-23T11:07:09.576Z]         Error: L6218E: Undefined symbol get_usb_phy() (referred from BUILD/tests/FUTURE_SEQUANA/ARM/TESTS/usb_device/hid/TESTS/usb_device/hid/main.o).

[2019-07-23T11:07:09.576Z] [2019-07-23T11:07:09.576Z]         Finished: 0 information, 3 warning and 1 error messages.

@svozcy
Copy link

svozcy commented Jul 23, 2019

@cypress-neil , it appears that targets.json enables USB Device for PSoC6 and FUTURE_SEQUANA what is not correct. The FUTURE_SEQUANA target must be updated because it does not support USB.

Copy link
Member

@fkjagodzinski fkjagodzinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@fkjagodzinski
Copy link
Member

@ARMmbed/mbed-os-hal Please review the proposed API. This USBPhyHw is quite generic name, but only provided by this one platform. Review if this is OK. Thanks.

@SeppoTakalo, this is fine, and actually follows our template (same as other tartgets) https://github.com/ARMmbed/mbed-os/blob/master/usb/device/targets/TARGET_Template/USBPhyHw.h

@mbed-ci
Copy link

mbed-ci commented Jul 26, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants