Checking if ignored dir is in the dir list before removing #1966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mbed-bot: TEST HOST_OSES=windows |
|
[Build 503] |
|
#1967 deprecated this one? |
|
I'd like to confirm #1967 fixes the issue on my side, shouldn't take long |
|
#1967 seems to be ok after local testing 👍 Closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an issue regarding ignored directories. When traversing the source tree, the
.mbedignorefiles dictate which directories should be "removed" from the traversal list. If this directory hasn't been added to this list before attempting to remove it, an Exception occurs and a traceback is printed to the user.This PR adds checks before removing dirs from the traversal list in the cases where the added directories are not being looped over exclusively.