Skip to content

Move ARMmbed/feature/FEATURE_BLE into mbedmicro/mbed. #2200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2016
Merged

Move ARMmbed/feature/FEATURE_BLE into mbedmicro/mbed. #2200

merged 1 commit into from
Jul 21, 2016

Conversation

pan-
Copy link
Member

@pan- pan- commented Jul 20, 2016

In the process, the path has been shortened and the unnecessary ble (see here)
directory between FEATURE_BLE and the actual implementation has been
removed.

No other modifications were made for this import.

commit id of ARMmbed : 17728a8

@pan-
Move ARMmbed/feature/FEATURE_BLE into mbedmicro/mbed.
2259e0d 
In the process, the path has been shortened and the unecessary ble
directory between FEATURE_BLE and the actual implementation has been
removed.

commit id of ARMmbed : 17728a8
@pan-
Copy link
Member Author

pan- commented Jul 20, 2016

@sg- could you review this ?

@sg-
Copy link
Contributor

sg- commented Jul 21, 2016

@mbed-bot: TEST

HOST_OSES=windows,linux
BUILD_TOOLCHAINS=GCC_ARM,ARM,IAR
TARGETS=K64F,NRF51_DK,NRF51_MICROBIT,NUCLEO_F411RE,KL25Z

@mbed-bot
Copy link

[Build 658]
FAILURE: Something went wrong when building and testing.

@sg-
Copy link
Contributor

sg- commented Jul 21, 2016

Looks like microbit fails RTOS tests for ARM toolchain http://mbedci.cloudapp.net/#/builds/658/tests

@pan-
Copy link
Member Author

pan- commented Jul 21, 2016

@sg- Memory issues on this platform can arrive very quickly when the RTOS is on especially since we set up the main stack to 2048 (needed by BLE activities).
It was chosen to run a single thread of execution and set the build configuration to small.

When compiled with GCC, the system recognized that those tests as not supported but not with ARMCC.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 21, 2016

Looks like microbit fails RTOS tests for ARM toolchain http://mbedci.cloudapp.net/#/builds/658/tests

Not a regression.

LGTM

@0xc0170 0xc0170 merged commit db60d6a into ARMmbed:master Jul 21, 2016
@pan- pan- deleted the ble_integration_from_mbed_os branch July 3, 2018 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pan- @sg- @mbed-bot @0xc0170