ISR register never re-evaluated in HAL_DMA_PollForTransfer for STM32F4 #3393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
|
Thanks for posting the test results @andreaslarssonublox! They look good! |
aisair
pushed a commit
to aisair/mbed
that referenced
this pull request
Apr 30, 2024
Ports for Upcoming Targets 3241: Add support for FRDM-KW41 ARMmbed/mbed-os#3241 3291: Adding mbed enabled Maker board with NINA-B1 and EVA-M8Q ARMmbed/mbed-os#3291 Fixes and Changes 3062: TARGET_STM :USB device FS ARMmbed/mbed-os#3062 3213: STM32: Refactor us_ticker.c + hal_tick.c files ARMmbed/mbed-os#3213 3288: Dev spi asynch l0l1 ARMmbed/mbed-os#3288 3289: Bug fix of initial value of interrupt edge in "gpio_irq_init" function. ARMmbed/mbed-os#3289 3302: STM32F4 AnalogIn - Clear VBATE and TSVREFE bits before configuring ADC channels ARMmbed/mbed-os#3302 3320: STM32 - Add ADC_VREF label ARMmbed/mbed-os#3320 3321: no HSE available by default for NUCLEO_L432KC ARMmbed/mbed-os#3321 3352: ublox eva nina - fix line endings ARMmbed/mbed-os#3352 3322: DISCO_L053C8 doesn't support LSE ARMmbed/mbed-os#3322 3345: STM32 - Remove TIM_IT_UPDATE flag in HAL_Suspend/ResumeTick functions ARMmbed/mbed-os#3345 3309: [NUC472/M453] Fix CI failed tests ARMmbed/mbed-os#3309 3157: [Silicon Labs] Adding support for EFR32MG1 wireless SoC ARMmbed/mbed-os#3157 3301: I2C - correct return values for write functions (docs) - part 1 ARMmbed/mbed-os#3301 3303: Fix #2956 #2939 #2957 #2959 #2960: Add HAL_DeInit function in gpio_irq destructor ARMmbed/mbed-os#3303 3304: STM32L476: no HSE is present in NUCLEO and DISCO boards ARMmbed/mbed-os#3304 3318: Register map changes for RevG ARMmbed/mbed-os#3318 3317: NUCLEO_F429ZI has integrated LSE ARMmbed/mbed-os#3317 3312: K64F: SPI Asynch API implementation ARMmbed/mbed-os#3312 3324: Dev i2c common code ARMmbed/mbed-os#3324 3369: Add CAN2 missing pins for connector CN12 ARMmbed/mbed-os#3369 3377: STM32 NUCLEO-L152RE Update system core clock to 32MHz ARMmbed/mbed-os#3377 3378: K66F: Enable LWIP feature ARMmbed/mbed-os#3378 3382: [MAX32620] Fixing serial readable function. ARMmbed/mbed-os#3382 3399: NUCLEO_F103RB - Add SERIAL_FC feature ARMmbed/mbed-os#3399 3409: STM32L1 : map ST HAL assert into MBED assert ARMmbed/mbed-os#3409 3416: Renames i2c_api.c for STM32F1 targets to fix IAR exporter ARMmbed/mbed-os#3416 3348: Fix frequency function of CAN driver. ARMmbed/mbed-os#3348 3366: NUCLEO_F412ZG - Add new platform ARMmbed/mbed-os#3366 3379: STM32F0 : map ST HAL assert into MBED assert ARMmbed/mbed-os#3379 3393: ISR register never re-evaluated in HAL_DMA_PollForTransfer for STM32F4 ARMmbed/mbed-os#3393 3408: STM32F7 : map ST HAL assert into MBED assert ARMmbed/mbed-os#3408 3411: STM32L0 : map ST HAL assert into MBED assert ARMmbed/mbed-os#3411 3424: STM32F4 - FIX to add the update of hdma->State variable ARMmbed/mbed-os#3424 3427: Fix stm i2c slave ARMmbed/mbed-os#3427 3429: Fix stm i2c fix init ARMmbed/mbed-os#3429 3434: [NUC472/M453] Fix stuck in lp_ticker_init and other updates ARMmbed/mbed-os#3434
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The ISR register is never re-evaluated in HAL_DMA_PollForTransfer for STM32F4.
This will cause the function to unnecessarily wait for timeout in some circumstances.
Putting 'tmpisr = regs->ISR;' at the end of the while loop solves it for the ODIN driver.
Status
READY
Migrations
NO
Related PRs
#3272
Todos
Review by @LMESTM
Deploy notes
None
Steps to test or reproduce
This has been reproduced with the private repo of the u-blox ODIN-drivers and the fix can therefore only be verified by u-blox for the UBLOX_EVK_ODIN_W2 target. The current ODIN-W2 driver binary for mbed-os v5.3.0 has a workaround therefore it's not affected.
The tests below have been run with the fix in the PR and without the workaround.
test_report_arm.txt
test_report_gcc.txt
test_report_iar.txt