Remove ARM7 support and targets #4307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theotherjimmy
changed the title
|
/morph test |
|
/morph mbed2-release |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
|
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
bulislaw
approved these changes
May 12, 2017
pan-
approved these changes
May 12, 2017
geky
approved these changes
May 12, 2017
Merge when CI is green. |
|
@theotherjimmy Need a message for deprecated targets when people try to compile for them |
|
@sg- They're removed from targets.json. It will do the same as other targets that don't exist and tell the user that it did not understand the input and list the options. If you want something else, then you're asking for a hack. |
|
Its a breaking change and therefore deserves a nice message. Same will be true for Cortex A for mbed OS 5.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove ARM7 targets since they are no longer supported.
This is a cherry pick of aa5f1ae from the CMSIS_5 branch.