Skip to content

Collect ignored directories in scan and use in exporters #4783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

theotherjimmy
Copy link
Contributor

This patch set resolves issue #3919 by unifying the logic for computing
excluded paths into scan_resources. This relieves the exporter from
having to compute this information itself, and significantly speeds up
exporters that had to compute exclusions (GNU ARM Eclipse at this time).

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 20, 2017

Is travis failure related?

Scan: FEATURE_IPV4
FAILED!
    List of features doesn't match
    Expected: 'IPV4,STORAGE,UVISOR'
    Got: 'IPV4,STORAGE,UVISOR'
test25:'test recursive feature collisions'(K64F) Scan: test25
Scan: FEATURE_STORAGE
FAILED!
    Expected key 'exception_msg' was not found in configuration data
test26:'test recursive feature configurations'(test_target) Scan: test26
Scan: FEATURE_IPV4
FAILED!
    Error while getting configuration!
    Attempt to override undefined parameter 'lib2.test' in 'application[*]'
test27:'test removing features'(test_target) Scan: test27
OK
test28:'test uvisor feature'(test_target) Scan: test28
OK
test29:'error when bootloader not found'(K64F) OK

@theotherjimmy theotherjimmy force-pushed the refactor-exporter-ignores branch from 9d31b87 to c8e6cf5 Compare July 26, 2017 19:31
@theotherjimmy
Copy link
Contributor Author

@0xc0170 Real failure. Should be fixed.

@theotherjimmy
Copy link
Contributor Author

/morph export-build

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 97

All exports and builds passed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants