Skip to content

LPC546XX: Add check for GPIO IRQ #6735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2018
Merged

LPC546XX: Add check for GPIO IRQ #6735

merged 1 commit into from
Apr 25, 2018

Conversation

mmahadevan108
Copy link
Contributor

@mmahadevan108 mmahadevan108 commented Apr 24, 2018 •
edited by 0xc0170
Loading

Description

GPIO IRQ is available on pins for Ports 0 & 1. Add a check to return error for other ports.

PR type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@mmahadevan108
LPC546XX: Add check for GPIO IRQ
6513091 
GPIO IRQ is available on pins for Ports 0 & 1. Add
a check to return error for other ports.

Signed-off-by: Mahesh Mahadevan <[email protected]>
@mmahadevan108
Copy link
Contributor Author

cc @maclobdell @0xc0170 @cmonr

cmonr
cmonr approved these changes Apr 24, 2018
View reviewed changes
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

cmonr
cmonr reviewed Apr 24, 2018
View reviewed changes
targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_LPC/gpio_irq_api.c
@@ -25,6 +25,8 @@
#include "fsl_pint.h"
#include "mbed_error.h"

#define INTERRUPT_PORTS 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose all LPC targets only have two ports that are interruptible?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

@cmonr cmonr requested review from 0xc0170 and maclobdell April 24, 2018 19:38
@cmonr
Copy link
Contributor

cmonr commented Apr 24, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Apr 24, 2018

Build : SUCCESS

Build number : 1845
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6735/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Apr 24, 2018

Exporter Build : SUCCESS

Build number : 1491
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6735/

@mbed-ci
Copy link

mbed-ci commented Apr 25, 2018

Test : SUCCESS

Build number : 1654
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6735/1654

@0xc0170 0xc0170 merged commit beb8da9 into ARMmbed:master Apr 25, 2018
@mmahadevan108 mmahadevan108 deleted the Add_GPIO_IRQ_Check branch May 1, 2018 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@maclobdell maclobdell Awaiting requested review from maclobdell

Assignees
No one assigned
Labels
release-version: 5.8.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmahadevan108 @cmonr @mbed-ci @0xc0170