Lora: Split add_mac_command() into separate methods #6741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to have smaller and better testable methods, instead of having a big switch-case -style add_mac_command(), each MAC command is now separated to an own method.
|
@hasnainvirk @AnttiKauppila @kjbracey-arm please review. |
AnttiKauppila
approved these changes
Apr 25, 2018
hasnainvirk
approved these changes
Apr 26, 2018
| << 8; | ||
| rxParamSetupReq.frequency |= (uint32_t) payload[mac_index++] | ||
| << 16; | ||
| rxParamSetupReq.frequency |= (uint32_t) payload[mac_index++] << 8; |
|
/morph build |
Build : SUCCESSBuild number : 1862 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 1510 |
Test : SUCCESSBuild number : 1674 |
cmonr
approved these changes
Apr 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to have smaller and better testable methods, instead of having a big
switch-case -style add_mac_command(), each MAC command is now separated to an
own method.
This has been tested with our internal Lora tests.
Pull request type