Skip to content

Mbed Stats: Assert if NULL pointer passed as arg #6809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2018

Conversation

deepikabhavnani
Copy link

@deepikabhavnani deepikabhavnani commented May 3, 2018

Description

Check for NULL pointer before access to any parameter. API arguments must be verified before access.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@deepikabhavnani deepikabhavnani changed the title Check for NULL pointer before access Mbed Stats: Assert if NULL pointer passed as arg May 3, 2018
@0xc0170 0xc0170 requested a review from geky May 4, 2018 08:50
@cmonr
Copy link
Contributor

cmonr commented May 7, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented May 7, 2018

Build : SUCCESS

Build number : 1930
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6809/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented May 7, 2018

@mbed-ci
Copy link

mbed-ci commented May 7, 2018

@cmonr
Copy link
Contributor

cmonr commented May 7, 2018

@studavekar Not sure if you're tracking this, but the failed exporter build job failed with symbols being multiply defined.

/morph export-build

@mbed-ci
Copy link

mbed-ci commented May 8, 2018

Exporter Build : FAILURE

Build number : 1585
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6809/

@0xc0170
Copy link
Contributor

0xc0170 commented May 8, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented May 8, 2018

Exporter Build : FAILURE

Build number : 1590
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6809/

@deepikabhavnani
Copy link
Author

Build number : 1590

@cmonr @studavekar - No failure artifacts

@cmonr
Copy link
Contributor

cmonr commented May 8, 2018

@deepikabhavnani Correct. In this particular instance, looks like Jenkins borked:

java.io.EOFException> 07:09:08 FATAL: command execution failed
07:09:08 java.io.EOFException
07:09:08 	at java.io.ObjectInputStream$PeekInputStream.readFully(ObjectInputStream.java:2675)
07:09:08 	at java.io.ObjectInputStream$BlockDataInputStream.readShort(ObjectInputStream.java:3150)
07:09:08 	at java.io.ObjectInputStream.readStreamHeader(ObjectInputStream.java:859)
07:09:08 	at java.io.ObjectInputStream.<init>(ObjectInputStream.java:355)
07:09:08 	at hudson.remoting.ObjectInputStreamEx.<init>(ObjectInputStreamEx.java:48)
07:09:08 	at hudson.remoting.AbstractSynchronousByteArrayCommandTransport.read(AbstractSynchronousByteArrayCommandTransport.java:35)
07:09:08 	at hudson.remoting.SynchronousCommandTransport$ReaderThread.run(SynchronousCommandTransport.java:63)
07:09:08 Caused: java.io.IOException: Unexpected termination of the channel
07:09:08 	at hudson.remoting.SynchronousCommandTransport$ReaderThread.run(SynchronousCommandTransport.java:77)

Annoying that it's happened twice in a row... It's an ongoing issue we've been trying to root cause.
/morph export-build

@mbed-ci
Copy link

mbed-ci commented May 8, 2018

@cmonr
Copy link
Contributor

cmonr commented May 8, 2018

Restarting again since modifications to CI were made.
/morph export-build

@mbed-ci
Copy link

mbed-ci commented May 9, 2018

@cmonr cmonr merged commit a2370d5 into ARMmbed:master May 9, 2018
@deepikabhavnani deepikabhavnani deleted the add_assert branch May 9, 2018 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants