Skip to content

CPU Stats test - Increased wait time to allow device to sleep #6993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 24, 2018
Merged

CPU Stats test - Increased wait time to allow device to sleep #6993

merged 1 commit into from
May 24, 2018
+1 −1

Conversation

deepikabhavnani
Copy link

@deepikabhavnani deepikabhavnani commented May 23, 2018 •
edited
Loading

Description

With small wait time at the start, chances are that device does not enter sleep and idle time is zero. Increasing wait time to make sure device goes to sleep.

Issue seen in CI testing for NRF51_DK #6910 (comment)

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

CC @cmonr

Increased wait time to allow device to sleep
ea356a6 
With small wait time at the start, chances are that device does not
enter sleep and idle time is zero. Increasing wait time to make sure
device goes to sleep.
cmonr
cmonr approved these changes May 23, 2018
View reviewed changes
Copy link
Contributor

@cmonr cmonr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locally tested many times, never failed.

Without this, local master branch failed every time.

@cmonr
Copy link
Contributor

cmonr commented May 23, 2018

/morph build

@cmonr cmonr mentioned this pull request May 23, 2018
Merged
@mbed-ci
Copy link

mbed-ci commented May 23, 2018

Build : SUCCESS

Build number : 2133
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6993/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

This was referenced May 24, 2018
Merged
Merged
Closed
Merged
@mbed-ci
Copy link

mbed-ci commented May 24, 2018

Exporter Build : SUCCESS

Build number : 1757
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6993/

@mbed-ci
Copy link

mbed-ci commented May 24, 2018

Test : SUCCESS

Build number : 1927
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6993/1927

@0xc0170 0xc0170 merged commit 1863400 into ARMmbed:master May 24, 2018
@kjbracey
Copy link
Contributor

Looks like the problem isn't totally cleared - just had a CI failure on #6983 - http://mbed-ci-master-2.austin.arm.com:8081/job/test_matrix_raas/1929/target=NRF51_DK,toolchain=IAR/

@kjbracey kjbracey mentioned this pull request May 24, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.9.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@deepikabhavnani @cmonr @mbed-ci @kjbracey @0xc0170