Corrected asynchronous DNS functionality #7016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set network stack to store event queue so that mbed::mbed_event_queue() call is not needed every time call_in() is called - Added dns state variables and enum (states are: created, initiated and cancelled) - Corrected DNS response handling so that if DNS server returns that host name is unknown the DNS query is not tried again - Reorder mutexes in nsapi_dns_query_multiple_async() - Created nsapi_dns_query_async_initiate_next() function to initiate the next DNS query from the queue after delete of previous query - Added dsn_timer_running variable to supervise DNS timer start/stop - Changed cancel function to only mark query as deleted and moved deletion to timer function. This allows to run socket close on DNS thread - Added new nsapi error NSAPI_ERROR_TIMEOUT for DNS (and other) timeouts
|
@kjbracey-arm Please review. |
SeppoTakalo
approved these changes
May 25, 2018
0xc0170
approved these changes
May 25, 2018
kjbracey
approved these changes
May 25, 2018
|
/morph build |
Build : SUCCESSBuild number : 2184 Triggering tests/morph test |
Test : SUCCESSBuild number : 1973 |
Exporter Build : SUCCESSBuild number : 1811 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Made fixes to asynchronous DNS. These are fixes to PR: #6847
List of changes:
is not needed every time call_in() is called
unknown the DNS query is not tried again
DNS query from the queue after delete of previous query
to timer function. This allows to run socket close on DNS thread
Pull request type