Skip to content

Tools: Remove second header when every bl config param is used #7196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2018

Conversation

theotherjimmy
Copy link
Contributor

Description

Resolves #7190

The issue is simple: the managed bootloader mode will accept both
target.bootloader_img and target.restrict_size at the same time.
When combined with target.header_format though, you end up with
two application headers, one before the application and one after.

This PR removes the second one; the after-application header.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple change, with a good description to boot.

@cmonr
Copy link
Contributor

cmonr commented Jun 13, 2018

Holding off on CI until the Test pipeline is a bit shorter.

@cmonr
Copy link
Contributor

cmonr commented Jun 13, 2018

Getting this in the queue since we're restarting other paused tests.
/morph test

@mbed-ci
Copy link

mbed-ci commented Jun 14, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 14, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jun 14, 2018

Build : SUCCESS

Build number : 2351
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7196/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 14, 2018

@mbed-ci
Copy link

mbed-ci commented Jun 15, 2018

@adbridge adbridge merged commit 4d8dd59 into ARMmbed:master Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants