Skip to content

Fix SPI initialization for NRF52 series #7280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2018
Merged

Fix SPI initialization for NRF52 series #7280

merged 1 commit into from
Jun 21, 2018
+14 −2

Conversation

marcuschangarm
Copy link
Contributor

Description

New changes to Mbed error reporting in 5.9 exposed bug in SPI driver where an instance was uninitialized twice which triggered an ASSERT.

This fix keeps track of which instance has been initialized and only calls uninit when it is safe.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

Fix SPI initialization for NRF52 series
6cec180 
New changes to Mbed error reporting in 5.9 exposed bug in SPI
driver where an instance was uninitialized twice which triggered
an ASSERT.

This fix keeps track of which instance has been initialized and
only calls uninit when it is safe.
@marcuschangarm marcuschangarm mentioned this pull request Jun 20, 2018
Closed
@cmonr
Copy link
Contributor

cmonr commented Jun 20, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jun 20, 2018

Build : SUCCESS

Build number : 2407
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7280/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 21, 2018

Exporter Build : SUCCESS

Build number : 2042
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7280/

@mbed-ci
Copy link

mbed-ci commented Jun 21, 2018

Test : SUCCESS

Build number : 2193
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7280/2193

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 21, 2018

Fixes #7278

@cmonr cmonr merged commit b80490d into ARMmbed:master Jun 21, 2018
@marcuschangarm marcuschangarm mentioned this pull request Jul 5, 2018
Closed
@marcuschangarm marcuschangarm deleted the fix-spi branch July 9, 2018 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.9.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcuschangarm @cmonr @mbed-ci @0xc0170