Skip to content

Replace build profile changes with config #7449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

theotherjimmy
Copy link
Contributor

@theotherjimmy theotherjimmy commented Jul 9, 2018

Description

Changes to build profiles need to come with a bump to the online
compiler profiles. These changes that I'm reverting do not need to
happen, so instead of using the build profiles, we should use
something else. There's this handy-dandy macros thing in the config
system. Let's use that.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 10, 2018

/morph build

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 10, 2018

This must be in 5.9.3

@mbed-ci
Copy link

mbed-ci commented Jul 10, 2018

Build : SUCCESS

Build number : 2556
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7449/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

Copy link
Contributor

@JanneKiiskila JanneKiiskila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mbed-ci
Copy link

mbed-ci commented Jul 10, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 10, 2018

@theotherjimmy Travis is having issues to get the commit? Please review

@theotherjimmy
Copy link
Contributor Author

@0xc0170 I have restarted it a few times myself, but I can't seem to get it to go through. This is strictly not a problem with the code though, so I contest the needs: work label.

@MarceloSalazar
Copy link

Internal reference: IOTMORF-2418

@cmonr
Copy link
Contributor

cmonr commented Jul 11, 2018

git checkout -qf 15e7a30cefe05cab5b9876d08b312cca9b7075d0
fatal: reference is not a tree: 15e7a30cefe05cab5b9876d08b312cca9b7075d0

@cmonr
Copy link
Contributor

cmonr commented Jul 11, 2018

There's definitely something funky going on with Travis and this PR. Going to try to close and reopen this PR to see if it sorts itself out.

@MarceloSalazar Fyi, since this might mess with your script.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 11, 2018

I can't find a way to make travis pass, thus I created a new PR to test Travis. If it passes, lets use 7474 PR instead.

@cmonr
Copy link
Contributor

cmonr commented Jul 11, 2018

Agreed moving to #7474.

@cmonr cmonr closed this Jul 11, 2018
@mbed-ci
Copy link

mbed-ci commented Jul 11, 2018

Build : SUCCESS

Build number : 2567
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7449/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jul 11, 2018

@mbed-ci
Copy link

mbed-ci commented Jul 11, 2018

@cmonr
Copy link
Contributor

cmonr commented Jul 11, 2018

@studavekar @OPpuolitaival FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants