-
Notifications
You must be signed in to change notification settings - Fork 3k
Replace build profile changes with config #7449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/morph build |
This must be in 5.9.3 |
Build : SUCCESSBuild number : 2556 Triggering tests/morph test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Test : SUCCESSBuild number : 2313 |
@theotherjimmy Travis is having issues to get the commit? Please review |
@0xc0170 I have restarted it a few times myself, but I can't seem to get it to go through. This is strictly not a problem with the code though, so I contest the needs: work label. |
Internal reference: IOTMORF-2418 |
|
There's definitely something funky going on with Travis and this PR. Going to try to close and reopen this PR to see if it sorts itself out. @MarceloSalazar Fyi, since this might mess with your script. |
I can't find a way to make travis pass, thus I created a new PR to test Travis. If it passes, lets use 7474 PR instead. |
Agreed moving to #7474. |
Build : SUCCESSBuild number : 2567 Triggering tests/morph test |
Exporter Build : FAILUREBuild number : 2211 |
Test : SUCCESSBuild number : 2321 |
Description
Changes to build profiles need to come with a bump to the online
compiler profiles. These changes that I'm reverting do not need to
happen, so instead of using the build profiles, we should use
something else. There's this handy-dandy macros thing in the config
system. Let's use that.
Pull request type