Skip to content

Remove extra ARMc6 instance in unique mapping #7544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2018

Conversation

cmonr
Copy link
Contributor

@cmonr cmonr commented Jul 18, 2018

Description

This recent commit (https://github.com/ARMmbed/mbed-os/pull/7302/files#diff-8ae3dde46b55f3a922724cd3585922b2) added ARMc6 which ends up multiplicly defining ARMc6 in what is suppose to be a set with unique entries.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@cmonr
Copy link
Contributor Author

cmonr commented Jul 18, 2018

/morph build

@cmonr
Copy link
Contributor Author

cmonr commented Jul 18, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jul 18, 2018

Build : FAILURE

Build number : 2638
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7544/

@mbed-ci
Copy link

mbed-ci commented Jul 19, 2018

Build : ABORTED

Build number : 2639
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7544/

@cmonr
Copy link
Contributor Author

cmonr commented Jul 19, 2018

Going to try this again since CI is now quiet.

/morph build

@cmonr
Copy link
Contributor Author

cmonr commented Jul 19, 2018

@ARMmbed/mbed-os-maintainers Thoughts about bringing this in without CI?
@ARMmbed/mbed-os-test

Details: The original CI problem was that when the mbed compile -S or other -S commands are used, the CI build pipeline fails before the PR can even be applied. Because of this, no PRs will be aleo to run until this PR is merged in, which creates a cyclical dependency.
I've opened a ticket in Jira asking for a possible Jenkins change/update, but wanted to discuss this alternative as well.

@cmonr
Copy link
Contributor Author

cmonr commented Jul 19, 2018

Different note: A failed export job appears to indicate that IAR builds are having network and/or machine issues: http://mbed-os.s3-eu-west-1.amazonaws.com/builds/exporter/7479/FAIL/K82F/make_iar/86491627bf80d1b5e5d3b92dabc242d556304e0c_exporter_build_log_K82F_make_iar.txt

@mbed-ci
Copy link

mbed-ci commented Jul 19, 2018

Build : FAILURE

Build number : 2641
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7544/

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 19, 2018

CI IAR issue still needs to be fixed anyway, I'll talk to @OPpuolitaival.

I would like to have this green asap

@0xc0170 0xc0170 changed the title Removed extra ARMc6 instance in unique mapping Remove extra ARMc6 instance in unique mapping Jul 19, 2018
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 19, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jul 19, 2018

Build : SUCCESS

Build number : 2642
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7544/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jul 19, 2018

@mbed-ci
Copy link

mbed-ci commented Jul 19, 2018

@cmonr cmonr merged commit 49ae504 into ARMmbed:master Jul 19, 2018
@0xc0170 0xc0170 removed the needs: CI label Jul 19, 2018
pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
Remove extra ARMc6 instance in unique mapping
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants