Skip to content

netsocket: astyle fix #7692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 7, 2018
Merged

netsocket: astyle fix #7692

merged 2 commits into from
Aug 7, 2018

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Aug 3, 2018

Description

AStyle fix for netsockets

@ARMmbed/mbed-os-ipcore Please review

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested a review from a team August 3, 2018 12:34
0xc0170
0xc0170 commented Aug 3, 2018
View reviewed changes
features/netsocket/nsapi_dns.cpp Outdated
0x20, 0x01, 0x16, 0x08, 0, 0x10, 0, 0x25, // DNS.WATCH
0, 0, 0, 0, 0x1c, 0x04, 0xb1, 0x2f
}
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is just this change that looks fine but not same as the rest of the lines above.

@SeppoTakalo shall I manually fix it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhhh.. I did not spot this..
Astyle is trying to be clever and avoiding oneliners. If you cant somehow prevent these lines to be changed, please do.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 88a7416 commit

@0xc0170 0xc0170 requested a review from a team August 6, 2018 12:39
NirSonnenschein
NirSonnenschein reviewed Aug 6, 2018
View reviewed changes
Copy link
Contributor

@NirSonnenschein NirSonnenschein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look fine to me.

@cmonr
Copy link
Contributor

cmonr commented Aug 6, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Aug 6, 2018

Build : SUCCESS

Build number : 2747
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7692/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Aug 6, 2018

Exporter Build : SUCCESS

Build number : 2378
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7692/

@mbed-ci
Copy link

mbed-ci commented Aug 7, 2018

Test : SUCCESS

Build number : 2471
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7692/2471

@cmonr
Copy link
Contributor

cmonr commented Aug 7, 2018

/morph mbed2-build

@cmonr cmonr merged commit d84bf7f into ARMmbed:master Aug 7, 2018
@adbridge
Copy link
Contributor

This relies on #7192 which is scheduled for 5.10

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
Merge pull request ARMmbed#7692 from 0xc0170/fix_netsocket_style
35192d3 
netsocket: astyle fix
@0xc0170 0xc0170 deleted the fix_netsocket_style branch August 27, 2018 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

@cmonr cmonr cmonr approved these changes

@NirSonnenschein NirSonnenschein NirSonnenschein approved these changes

Assignees
No one assigned
Labels
release-version: 5.10.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@0xc0170 @cmonr @mbed-ci @adbridge @SeppoTakalo @NirSonnenschein