Skip to content

tests-mbed_hal-common_tickers: disable ticker free test cases. #7741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 16, 2018

Conversation

mprse
Copy link
Contributor

@mprse mprse commented Aug 9, 2018

Description

Resolves #7724.

Ticker free tests have been disabled since ticker free function has been implemented only for CI boards.
Implementation for the remaining platforms will be done on feature branch feature-hal-ticker-free.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Feature
[ ] Breaking change

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather have this completely removed (partial revert) than #if 0 . This will be on the feature branch and comes in once its widely adopted.

This is solution to issue ARMmbed#7724.

Ticker free tests have been removed since ticker free function has been implemented only for CI boards.
Implementation for the remaining platforms will be done on feature branch feature-hal-ticker-free.
@mprse mprse force-pushed the disable_ticker_free_tests branch from 8b0c6f9 to 20f3d87 Compare August 9, 2018 12:27
@mprse
Copy link
Contributor Author

mprse commented Aug 9, 2018

Fixed as suggested.

@0xc0170 0xc0170 requested a review from a team August 9, 2018 12:30
@cmonr
Copy link
Contributor

cmonr commented Aug 14, 2018

@mprse Once the Travis docs issue is resolved, we can start CI.

@mprse
Copy link
Contributor Author

mprse commented Aug 14, 2018

Removed requirements for ticker free function. This should solve the problem.

@cmonr
Copy link
Contributor

cmonr commented Aug 14, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Aug 14, 2018

Build : SUCCESS

Build number : 2813
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7741/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Aug 14, 2018

@mbed-ci
Copy link

mbed-ci commented Aug 16, 2018

@cmonr cmonr merged commit 3795d39 into ARMmbed:master Aug 16, 2018
pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
tests-mbed_hal-common_tickers: disable ticker free test cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants