Skip to content

Fix build_data functionality with python 3 #7769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 16, 2018

Conversation

OPpuolitaival
Copy link
Contributor

Description

Open file in non-binary mode because "The json module always produces str objects, not bytes objects. Therefore, fp.write() must support str input." https://docs.python.org/3.6/library/json.html#basic-usage

This found originally in here: https://circleci.com/gh/ARMmbed/mbed-cli/868

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Feature
[ ] Breaking change

@cmonr cmonr self-requested a review August 13, 2018 14:43
@cmonr
Copy link
Contributor

cmonr commented Aug 14, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Aug 14, 2018

Build : SUCCESS

Build number : 2810
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7769/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Aug 14, 2018

@mbed-ci
Copy link

mbed-ci commented Aug 16, 2018

@cmonr cmonr merged commit 354d555 into ARMmbed:master Aug 16, 2018
pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
Fix build_data functionality with python 3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants