Skip to content

Fix TMPM64B IAR linker file #7791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2018
Merged

Fix TMPM64B IAR linker file #7791

merged 1 commit into from
Aug 21, 2018

Conversation

davidsaada
Copy link
Contributor

Description

Remove unnecessary manual inclusion of tmpm64b_fc object file in linker script
This manual inclusion is unnecessary and causes linker issues when trying to add changes (as in #7212).

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Feature
[ ] Breaking change

Fix TMPM64B IAR linker file
f810e77 
Remove unnecessary manual inclusion of tmpm64b_fc object file in linker script
@davidsaada davidsaada mentioned this pull request Aug 14, 2018
Merged
NirSonnenschein
NirSonnenschein approved these changes Aug 14, 2018
View reviewed changes
Copy link
Contributor

@NirSonnenschein NirSonnenschein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok to me

@davidsaada
Copy link
Contributor Author

@dannybenor

@dannybenor
Copy link

Looks good, go ahead

@NirSonnenschein
Copy link
Contributor

Hi @dannybenor , we need a technical review as part of the review process, can you please approve so we can move this into CI?

@cmonr
Copy link
Contributor

cmonr commented Aug 15, 2018

Wil start CI when CI load has decreased.

@cmonr
Copy link
Contributor

cmonr commented Aug 17, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Aug 17, 2018

Build : SUCCESS

Build number : 2824
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7791/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Aug 17, 2018

Exporter Build : SUCCESS

Build number : 2454
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7791/

@mbed-ci
Copy link

mbed-ci commented Aug 18, 2018

Test : SUCCESS

Build number : 2575
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7791/2575

@NirSonnenschein
Copy link
Contributor

/morph uvisor-test

1 similar comment
@0xc0170
Copy link
Contributor

0xc0170 commented Aug 21, 2018

/morph uvisor-test

@cmonr cmonr merged commit fa4b2f0 into ARMmbed:master Aug 21, 2018
@davidsaada davidsaada deleted the david_fix_tmpm64b_iar_linker_file branch August 22, 2018 09:08
pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
Merge pull request ARMmbed#7791 from davidsaada/david_fix_tmpm64b_iar…
0b300bc 
…_linker_file

Fix TMPM64B IAR linker file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannybenor dannybenor dannybenor approved these changes

@NirSonnenschein NirSonnenschein NirSonnenschein approved these changes

Assignees
No one assigned
Labels
release-version: 5.9.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@davidsaada @dannybenor @NirSonnenschein @cmonr @mbed-ci @0xc0170