Skip to content

NFC: fix reading from NFC EEPROM #7964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2018
Merged

Conversation

paul-szczepanek-arm
Copy link
Member

Description

Reading operation returns failure despite succeeding because the closing of the session fails. This happens because it's not setting the current operation at the end of reading so when session is ended successfully the event is unexpected (since it's missing the current op set correctly) and hence returns a failure despite just succeeding. This fix adds that missing assignment to the current op.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

added missing current op
@donatieng donatieng changed the title BLE: fix reading from NFCEEPROM NFC: fix reading from NFC EEPROM Sep 3, 2018
@donatieng
Copy link
Contributor

@ARMmbed/mbed-os-maintainers this one is not critical and can get in after RC1 as this specific flow is not being tested by the examples in OOB

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 4, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 4, 2018

Build : SUCCESS

Build number : 3001
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7964/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 4, 2018

@mbed-ci
Copy link

mbed-ci commented Sep 4, 2018

@cmonr
Copy link
Contributor

cmonr commented Sep 4, 2018

"Error initializing storage"...

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Sep 5, 2018

@0xc0170 0xc0170 merged commit 3057c6c into ARMmbed:master Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants