-
Notifications
You must be signed in to change notification settings - Fork 3k
Reverting PinNames.h after PR #7774 changes #7995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…mit reverts those files excpet for K82F and K64F which are left as an example
cc @ARMmbed/team-nuvoton @ARMmbed/team-silabs @ARMmbed/team-st-mcd @ARMmbed/team-nxp @ARMmbed/team-realtek |
@jeromecoutant Good with this revert? Due to the time constraints of when this needs to get into RC2, we only have about 24 hrs to get an OK from partners. |
/morph build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Build : SUCCESSBuild number : 3021 Triggering tests/morph test |
Test : SUCCESSBuild number : 2788 |
Exporter Build : SUCCESSBuild number : 2636 |
Hi #7774 added SPI_PERSISTENT_MEM_CS in 31 targets Why did you keep 3 of them ? |
@yossi2le @ARMmbed/mbed-os-storage Thoughts to the above question? |
We revert the PinNames.h files after #7774 because we haven't communicated it so well with all the relevant partners and teams. After #7774 was merged there was some discussion regarding this change and AFAIK it was decided that we leave K82F and K64F boards as an example, while we start the correct procedure of adding those pins into the PinsNames.h. This procedure should be done by conducting a proper dialogue with all the relevant partners and teams. |
Description
In PR #7774 we have changed PinNames.h for various targets. Unfortunately, this was a mistake and those changes should not be done by us. Therefore this PR initiate a revert for those file.
We will open a discussion with the relevant stakeholders to enable this change in the future.
Pull request type