Skip to content

Reverting PinNames.h after PR #7774 changes #7995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2018

Conversation

yossi2le
Copy link
Contributor

@yossi2le yossi2le commented Sep 5, 2018

Description

In PR #7774 we have changed PinNames.h for various targets. Unfortunately, this was a mistake and those changes should not be done by us. Therefore this PR initiate a revert for those file.
We will open a discussion with the relevant stakeholders to enable this change in the future.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

…mit reverts those files excpet for K82F and K64F which are left as an example
@0xc0170
Copy link
Contributor

0xc0170 commented Sep 5, 2018

cc @ARMmbed/team-nuvoton @ARMmbed/team-silabs @ARMmbed/team-st-mcd @ARMmbed/team-nxp @ARMmbed/team-realtek

@cmonr
Copy link
Contributor

cmonr commented Sep 5, 2018

@jeromecoutant Good with this revert?

Due to the time constraints of when this needs to get into RC2, we only have about 24 hrs to get an OK from partners.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 6, 2018

/morph build

@0xc0170 0xc0170 requested a review from a team September 6, 2018 10:53
Copy link
Contributor

@davidsaada davidsaada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mbed-ci
Copy link

mbed-ci commented Sep 6, 2018

Build : SUCCESS

Build number : 3021
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7995/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 6, 2018

@mbed-ci
Copy link

mbed-ci commented Sep 6, 2018

@cmonr cmonr merged commit ff1a0ed into ARMmbed:master Sep 6, 2018
@0xc0170 0xc0170 removed the needs: CI label Sep 6, 2018
@jeromecoutant
Copy link
Collaborator

Hi

#7774 added SPI_PERSISTENT_MEM_CS in 31 targets
This PR removed it from 28 targets...

Why did you keep 3 of them ?

@cmonr
Copy link
Contributor

cmonr commented Sep 24, 2018

@yossi2le @ARMmbed/mbed-os-storage Thoughts to the above question?

@yossi2le
Copy link
Contributor Author

We revert the PinNames.h files after #7774 because we haven't communicated it so well with all the relevant partners and teams. After #7774 was merged there was some discussion regarding this change and AFAIK it was decided that we leave K82F and K64F boards as an example, while we start the correct procedure of adding those pins into the PinsNames.h. This procedure should be done by conducting a proper dialogue with all the relevant partners and teams.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants