-
Notifications
You must be signed in to change notification settings - Fork 3k
Fix SocketAddress unittests #8086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add ip4tos() and stoip4() into unittests. NOTE: Probably should have been stubbed but this way we can also test these helper functions.
@lorjala please review |
Looks good, but is identical to this #8018 Which one we choose? This one implements actual headers. |
Oh... I prefer to pull in library code into unittests, so that the test can actually do something useful. |
@SeppoTakalo @OPpuolitaival @kjbracey-arm @lorjala If I understand, are we going to prefer this PR over #8018? |
@cmonr we're going with this. |
/morph build |
Build : SUCCESSBuild number : 3066 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2678 |
/morph test |
1 similar comment
/morph test |
Trying that again... |
Test : FAILUREBuild number : 2846 |
Stopped job to help root cause network issue. |
Kicking off again to see if we have more luck this morning! |
Test : SUCCESSBuild number : 2855 |
Description
Add ip4tos() and stoip4() into SocketAddress unittests.
NOTE: Probably should have been stubbed but this way we can also
test these helper functions.
#6293 Added usage of these helper functions, but by that time unit tests were not in place.
CC: @OPpuolitaival @kjbracey-arm
Pull request type