Skip to content

Fix SocketAddress unittests #8086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2018

Conversation

SeppoTakalo
Copy link
Contributor

Description

Add ip4tos() and stoip4() into SocketAddress unittests.
NOTE: Probably should have been stubbed but this way we can also
test these helper functions.

#6293 Added usage of these helper functions, but by that time unit tests were not in place.

CC: @OPpuolitaival @kjbracey-arm

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

Add ip4tos() and stoip4() into unittests.
NOTE: Probably should have been stubbed but this way we can also
test these helper functions.
@OPpuolitaival
Copy link
Contributor

@lorjala please review

@lorjala
Copy link
Contributor

lorjala commented Sep 12, 2018

Looks good, but is identical to this #8018

Which one we choose? This one implements actual headers.

@SeppoTakalo
Copy link
Contributor Author

Oh...
I would actually pull in the actual code into the test.
But I know some people would prefer dummy stubs that do nothing.

I prefer to pull in library code into unittests, so that the test can actually do something useful.

@cmonr
Copy link
Contributor

cmonr commented Sep 12, 2018

@SeppoTakalo @OPpuolitaival @kjbracey-arm @lorjala

If I understand, are we going to prefer this PR over #8018?

@lorjala
Copy link
Contributor

lorjala commented Sep 12, 2018

@cmonr we're going with this.

@cmonr
Copy link
Contributor

cmonr commented Sep 12, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 12, 2018

Build : SUCCESS

Build number : 3066
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8086/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 13, 2018

@adbridge
Copy link
Contributor

/morph test

1 similar comment
@cmonr
Copy link
Contributor

cmonr commented Sep 13, 2018

/morph test

@cmonr
Copy link
Contributor

cmonr commented Sep 13, 2018

Trying that again...
/morph test

@mbed-ci
Copy link

mbed-ci commented Sep 13, 2018

@cmonr
Copy link
Contributor

cmonr commented Sep 13, 2018

Stopped job to help root cause network issue.

@adbridge
Copy link
Contributor

Kicking off again to see if we have more luck this morning!
/morph test

@mbed-ci
Copy link

mbed-ci commented Sep 14, 2018

@cmonr cmonr merged commit 48d212f into ARMmbed:master Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants