Skip to content

[LPC4337] Fix RTC clock setting issue #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 25, 2014
Merged

[LPC4337] Fix RTC clock setting issue #815

merged 2 commits into from
Dec 25, 2014

Conversation

toyowata
Copy link
Contributor

  • Fixed missing RTC clock intialization code
  • Confirm to pass RTC test case (MBED_16)

@toyowata
[LPC4337] Fix RTC clock setting issue
44c66b1 
- Fixed missing RTC clock intialization code
- Confirm to pass RTC test case (MBED_16)
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 24, 2014

Can be that register read, to find out if rtc is enabled? I mean not to use private static variable to save the status of the peripheral but just retrieve it from hw.

@toyowata
[LPC4337] Remove init variable for RTC
7b62e7d 
- Remove static variable for initialization check
- Add enabled flag check for RTC control register
@toyowata
Copy link
Contributor Author

Agreed, I just changed to remove the static variable and add enabled flag check in the control register. Please can you review it.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 25, 2014

Thanks !

0xc0170 added a commit that referenced this pull request Dec 25, 2014
@0xc0170
Merge pull request #815 from toyowata/master
2f63fa7 
Targets: LPC4337 - Fix RTC clock setting issue
@0xc0170 0xc0170 merged commit 2f63fa7 into ARMmbed:master Dec 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toyowata @0xc0170