Skip to content

Improve flow control on NRF52 #8748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Improve flow control on NRF52 #8748

wants to merge 1 commit into from

Conversation

marcuschangarm
Copy link
Contributor

Description

Increase the time where the Clear-To-Send pin is de-asserted to minimize change of a character being lost when the DMA buffer is flushed manually.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Improve flow control on NRF52
3a14ec5 
Increase the time where the Clear-To-Send pin is de-asserted to
minimize change of a character being lost when the DMA buffer is
flushed manually.
@cmonr cmonr requested a review from a team November 14, 2018 22:51
cmonr
cmonr reviewed Nov 14, 2018
View reviewed changes
targets/TARGET_NORDIC/TARGET_NRF5x/TARGET_NRF52/serial_api.c
* Receive is halted until the buffer has been completely handled to reduce RAM usage.
*
* This signal is set manually because the flow control logic in the UARTE module
* only works when the module is receiving and not after an ENDRX event.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well that's annoying.

cmonr
cmonr approved these changes Nov 14, 2018
View reviewed changes
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 15, 2018

Is this related to the latest issue report regarding CI failures (losing some characters) ?

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 15, 2018

cc @mprse

@VeijoPesonen
Copy link
Contributor

cc @kjbracey-arm

@marcuschangarm
Copy link
Contributor Author

@0xc0170 Sure, if you enable flow control in the CI! 😄

@0xc0170 0xc0170 removed the request for review from a team November 19, 2018 12:31
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 20, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Nov 20, 2018

Build : SUCCESS

Build number : 3686
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8748/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Nov 20, 2018

Exporter Build : FAILURE

Build number : 3287
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8748/

@mbed-ci
Copy link

mbed-ci commented Nov 20, 2018

Test : FAILURE

Build number : 3460
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8748/3460

@marcuschangarm
Copy link
Contributor Author

This has been replaced by #8784

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@marcuschangarm @0xc0170 @VeijoPesonen @mbed-ci @cmonr @studavekar