Skip to content

Fix target handling in build.py #8932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2018
Merged

Fix target handling in build.py #8932

merged 1 commit into from
Dec 4, 2018

Conversation

orenc17
Copy link
Contributor

@orenc17 orenc17 commented Dec 1, 2018

Description

Fix issue #8912

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@orenc17 orenc17 mentioned this pull request Dec 1, 2018
Closed
@cmonr cmonr requested a review from a team December 1, 2018 23:28
cmonr
cmonr reviewed Dec 1, 2018
View reviewed changes
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmonr
Copy link
Contributor

cmonr commented Dec 1, 2018

Looks good to me, but @orenc17 minor nit. Would you mind adding back the new line space?

@cmonr cmonr requested a review from a team December 1, 2018 23:30
@orenc17
Copy link
Contributor Author

orenc17 commented Dec 2, 2018

@cmonr Done

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 3, 2018 •
edited
Loading

Travis failure will be fixed on master soon (we will request rebase once done). See #8945

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 3, 2018

Travis failure will be fixed on master soon (we will request rebase once done). See #8945

The fix is on master, if you rebase, it should allow travis to run

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 3, 2018

Labeled for 5.11.1 release

@cmonr
Copy link
Contributor

cmonr commented Dec 3, 2018

@orenc17

Rebase is needed to fix Travis CI issue.
Fix landed in master a few hours ago.

@orenc17
Copy link
Contributor Author

orenc17 commented Dec 3, 2018

@cmonr Done

@cmonr
Copy link
Contributor

cmonr commented Dec 3, 2018

CI started

@orenc17
Copy link
Contributor Author

orenc17 commented Dec 3, 2018 •
edited
Loading

@cmonr @0xc0170 this should be in rc2 as it fixes the options to build mbed-os as a library

@cmonr
Copy link
Contributor

cmonr commented Dec 3, 2018

@orenc17 Noted. Thanks for the heads up.

@mbed-ci
Copy link

mbed-ci commented Dec 4, 2018

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 1
Build artifacts
Build logs

@cmonr cmonr merged commit 6749a8a into ARMmbed:master Dec 4, 2018
@cmonr cmonr mentioned this pull request Dec 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@theotherjimmy theotherjimmy theotherjimmy approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.0-rc2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@orenc17 @cmonr @0xc0170 @mbed-ci @theotherjimmy