Turn off MPU for PSOC 6 #8952
Merged
Turn off MPU for PSOC 6 #8952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donatieng
approved these changes
Dec 3, 2018
alzix
approved these changes
Dec 3, 2018
| "release_versions": ["5"], | ||
| "extra_labels": ["Cypress", "PSOC6"], | ||
| "public": false | ||
| }, | ||
| "MCU_PSOC6_M0": { | ||
| "inherits": ["MCU_PSOC6"], | ||
| "core": "Cortex-M0+", | ||
| "macros": ["MCU_PSOC6_M0"], | ||
| "macros_add": ["MCU_PSOC6_M0"], |
There was a problem hiding this comment.
i think this one is not related to our MPU configuration, but clearly a necessary change!
Can you consider splitting it to separate commit?
|
fixes #8937 - once merged will close the issue automatically |
Use "macros_add" rather than "marcos" so any macros defined by MCU_PSOC6 are not overwritten.
Turn off the MPU for the PSOC 6 since it has a non-standard memory map. This fixes crashes on boot for this target.
alzix
approved these changes
Dec 3, 2018
cmonr
approved these changes
Dec 4, 2018
|
CI started |
0xc0170
approved these changes
Dec 4, 2018
Test run: SUCCESSSummary: 4 of 4 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Turn off the MPU for the PSOC 6 since it has a non-standard memory map. This fixes crashes on boot for this target.
fixes #8937
Pull request type