Correct behavior of PSA code generator #8964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikisch81
approved these changes
Dec 4, 2018
0xc0170
approved these changes
Dec 4, 2018
alzix
suggested changes
Dec 4, 2018
| @@ -1,83 +0,0 @@ | |||
| /* Copyright (c) 2017-2018 ARM Limited | |||
| * | |||
| * SPDX-License-Identifier: Apache-2.0 | |||
There was a problem hiding this comment.
what is the reason for removing this file as part of this PR?
There was a problem hiding this comment.
when the tool scans the psa test folder it should not generate a psa_setup.c file for tests that do not declare new partition
so this file is not needed anymore
|
This needs a rebase now. @alzix Rereview? |
|
Also, is this targeting RC3? |
* Don't generate files if a test does not contain additional partitions
alzix
approved these changes
Dec 6, 2018
|
rebased, it could be in RC3 |
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Don't generate files if a test does not contain additional partitions
Pull request type