Skip to content

Fix wrong PIN config for RTL8195AM platform #9045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2018
Merged

Fix wrong PIN config for RTL8195AM platform #9045

merged 1 commit into from
Dec 18, 2018

Conversation

fredlee12001
Copy link
Contributor

@fredlee12001 fredlee12001 commented Dec 11, 2018 •
edited by 0xc0170
Loading

Description

Merge from PelionIoT/sd-driver#110

For realtek RTL8195AM platform - the correct PIN for SPI-CS should be D10.

Pull request type

[ ] Fix
[ ] Refactor
[v ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom ciarmcom requested review from a team December 11, 2018 08:00
@ciarmcom
Copy link
Member

@fredlee12001, thank you for your changes.
@ARMmbed/mbed-os-storage @ARMmbed/mbed-os-maintainers please review.

@yossi2le
Copy link
Contributor

@fredlee12001 Just to verify, did you run any test to verify this change?

0xc0170
0xc0170 approved these changes Dec 11, 2018
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please describe how it was tested

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 18, 2018

@fredlee12001 Can we progress with this simple fix please?

@fredlee12001
Copy link
Contributor Author

With the wrong pin, Pelion Device Management Client can't working since SD init failed.
Only after we fix the PIN configuration, then PDMC works fine.

More details could be referred to PelionIoT/sd-driver#110

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 18, 2018

CI started

yossi2le
yossi2le approved these changes Dec 18, 2018
View reviewed changes
Copy link
Contributor

@yossi2le yossi2le left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10x for the fix.

@mbed-ci
Copy link

mbed-ci commented Dec 18, 2018

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit ce1929b into ARMmbed:master Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@yossi2le yossi2le yossi2le approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fredlee12001 @ciarmcom @yossi2le @0xc0170 @mbed-ci @cmonr