Move exit override to retarget.cpp #908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I moved the exit handler from exit.c to retarget.cpp where the rest of the standard C library retargetting routines are found. The exported makefiles already explicitly link in retarget.o but not exit.o When building with the GNU toolchain, it is safest to link in the object file directly for retargetting routines so that GNU linker has to use these versions of the routines. Testing: I have only tested this change with GCC_ARM. It should really be tested with more toolchains before getting merged.
|
I'll test it with other toolchains |
|
Tested with IAR and uVision, all green 🍏 |
|
@0xc0170 |
0xc0170
added a commit
to 0xc0170/mbed-os
that referenced
this pull request
Feb 16, 2015
0xc0170
added a commit
that referenced
this pull request
Feb 16, 2015
Fix for #908, exit req std namespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved the exit handler from exit.c to retarget.cpp where the rest of
the standard C library retargetting routines are found. The exported
makefiles already explicitly link in retarget.o but not exit.o
When building with the GNU toolchain, it is safest to link in the
object file directly for retargetting routines so that GNU linker has
to use these versions of the routines.
Testing:
I have only tested this change with GCC_ARM. It should really be
tested with more toolchains before getting merged.