Check correct ARMC6 predefine for FP codegen #9150
Merged
+13
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For ARMC6, CMSIS headers were checking the `__ARM_PCS_VFP`, which indicates hardfp ABI in use, when they need to check whether FP code generation is enabled. Change this to `__ARM_FP`, so it works for platforms using softfp ABI. Change already present in CMSIS_5 repo, via commit 969822ae162539d50617d1e5a3634ee2fd3b60f6, but redone with local search-and-replace.
|
@kjbracey-arm, thank you for your changes. |
0xc0170
approved these changes
Dec 19, 2018
|
Poking @ARMmbed/mbed-os-core for a review. @kjbracey-arm Making sure I understand, this is effectively a bugfix that has been applied in the upstream CMSIS repo? |
|
At least, that's the impression I get from #9142 (comment) |
|
@cmonr - yes it is fix pulled in from CMSIS to mbed-os. |
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For ARMC6, CMSIS headers were checking the
__ARM_PCS_VFP, which indicates hardfp ABI in use, when they need to check whether FP code generation is enabled. Change this to__ARM_FP, so it works for platforms using softfp ABI.Change already present in CMSIS_5 repo, via commit ARM-software/CMSIS_5@969822a, but redone with local search-and-replace.
Resolves #9142
Pull request type