Skip to content

Sleep manager implements all the API's in platform file #9280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 17, 2019

Conversation

deepikabhavnani
Copy link

Description

Sleep manager implements all the API's in platform/mbed_sleep_manager.h. Not sure why mbed_sleep_manager.c was in hal, moving it to platform.

Pull request type

[ ] Fix
[X] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ciarmcom ciarmcom requested review from a team January 8, 2019 00:00
@ciarmcom
Copy link
Member

ciarmcom commented Jan 8, 2019

@deepikabhavnani, thank you for your changes.
@ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@mattbrown015
Copy link
Contributor

Do you need to update the includes after a move like this?

In other words:

#include "platform/mbed_assert.h"
#include "platform/mbed_power_mgmt.h"
#include "platform/mbed_critical.h"
#include "sleep_api.h"

should become:

#include "mbed_assert.h"
#include "mbed_power_mgmt.h"
#include "mbed_critical.h"
#include "hal/sleep_api.h"

@deepikabhavnani
Copy link
Author

deepikabhavnani commented Jan 8, 2019

Do you need to update the includes after a move like this?

Thanks, updated headers 👍

@deepikabhavnani
Copy link
Author

@SenRamakri / @kegilbert - Please review

@deepikabhavnani
Copy link
Author

Rebased on top of master to pull in travis fixes

@deepikabhavnani
Copy link
Author

Rebased to resolve conflicts

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 15, 2019

This should be ready for CI, I'll label it as such, but please can you rebase again to get latest travis fix (once it is green we start CI)

deepikabhavnani added 2 commits January 15, 2019 11:47
….changes

Not sure why mbed_sleep_manager.c was in hal, moving it to platform
File was moved from hal -> platform folder, hence includes should be
changed accordingly.
@deepikabhavnani
Copy link
Author

This should be ready for CI, I'll label it as such, but please can you rebase again to get latest travis fix (once it is green we start CI)

Rebase done 👍

@cmonr
Copy link
Contributor

cmonr commented Jan 17, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 17, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit a1daecb into ARMmbed:master Jan 17, 2019
@deepikabhavnani deepikabhavnani deleted the refactor_a branch January 23, 2019 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants