Skip to content

Fix Py3.7 mdot target build #9673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 13, 2019
Merged

Fix Py3.7 mdot target build #9673

merged 2 commits into from
Feb 13, 2019

Conversation

cmonr
Copy link
Contributor

@cmonr cmonr commented Feb 12, 2019

Description

Fixes #8618

In addition to the byte/string issue, there was an additional decode that is no longer needed.

Tested with mbed test --compile -m GCC_ARM -t MTS_MDOT_F411RE and pytest (reference .travis.yml for command)

  • Succeeds with both 2.7.15 and 3.7.2

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@cmonr cmonr requested a review from a team February 12, 2019 02:21
@ciarmcom ciarmcom requested a review from a team February 12, 2019 04:00
@ciarmcom
Copy link
Member

@cmonr, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

3 similar comments
@ciarmcom
Copy link
Member

@cmonr, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@ciarmcom
Copy link
Member

@cmonr, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@ciarmcom
Copy link
Member

@cmonr, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@vmedcy vmedcy mentioned this pull request Feb 12, 2019
Closed
@cmonr
Copy link
Contributor Author

cmonr commented Feb 12, 2019

Also fixes #9618

Two birds with one stone ^_^

@cmonr
Copy link
Contributor Author

cmonr commented Feb 12, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 12, 2019

Test run: FAILED

Summary: 2 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@cmonr
Copy link
Contributor Author

cmonr commented Feb 12, 2019

NOTE: This PR has now been rebased.

If this was made in error, feel free to force-push your local branch to restore the PR.

@cmonr cmonr force-pushed the fix-py3-MDOT-build branch from 780f562 to b59bb46 Compare February 12, 2019 18:08
@cmonr
Copy link
Contributor Author

cmonr commented Feb 12, 2019

CI started

@alekla01
Copy link
Contributor

Restarted CI after #9677

@mbed-ci
Copy link

mbed-ci commented Feb 12, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 2
Build artifacts

@cmonr cmonr merged commit 3d7995e into ARMmbed:master Feb 13, 2019
This was referenced Feb 13, 2019
Closed
Merged
@bridadan bridadan mentioned this pull request Feb 19, 2019
Closed
@jackyhuang85 jackyhuang85 mentioned this pull request Mar 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@bridadan bridadan bridadan approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cmonr @ciarmcom @mbed-ci @alekla01 @0xc0170 @bridadan