Skip to content

Cellular: Fix cellular stack and drivers for netsocket tests #9705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 19, 2019
Merged

Cellular: Fix cellular stack and drivers for netsocket tests #9705

merged 6 commits into from
Feb 19, 2019

Conversation

AriParkkila
Copy link

Description

Fix cellular stack and drivers:

  • Handling of TCP endpoint closed
  • AT debugging relieved
  • Cinterion drivers to retry on socket open failure
  • Various fixes for Quectel BG96 and M26 drivers

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@mirelachirica

@ciarmcom ciarmcom requested review from mirelachirica and a team February 13, 2019 12:00
@ciarmcom
Copy link
Member

@AriParkkila, thank you for your changes.
@mirelachirica @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@ciarmcom
Copy link
Member

@AriParkkila, thank you for your changes.
@mirelachirica @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

mirelachirica
mirelachirica reviewed Feb 15, 2019
View reviewed changes
@AriParkkila
Copy link
Author

@mirelachirica please re-review

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 15, 2019

Trying to understand the need to squash all these fixes into one. Why?

I would rather leave them as described:

  • Handling of TCP endpoint closed
  • AT debugging relieved
  • Cinterion drivers to retry on socket open failure
  • Various fixes for Quectel BG96 and M26 drivers

Than having all in one.

@AriParkkila
Copy link
Author

@0xc0170 do you mean that one commit per each change, if so I can split this to many commits.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 15, 2019

@0xc0170 do you mean that one commit per each change, if so I can split this to many commits.

yes, please if you agree that they can be separated logically into own commits.

@AriParkkila
Copy link
Author

@0xc0170 split to logical commits, should be ready for merge.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 18, 2019

Thanks for the rework, looks good.
For future reference, describe fixings with "how is this being fixed and why". This is good as it is "Cellular: Fix CellularDevice mutex unlock" but commit like "Cellular: Handling of TCP endpoint closed" might be better with a description.

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 18, 2019

Test run: FAILED

Summary: 1 of 1 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_unittests

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 18, 2019

Please review test failures

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 19, 2019

CI restarted

@mbed-ci
Copy link

mbed-ci commented Feb 19, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 merged commit 400fd82 into ARMmbed:master Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@AnttiKauppila AnttiKauppila AnttiKauppila approved these changes

@mirelachirica mirelachirica mirelachirica approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@AriParkkila @ciarmcom @0xc0170 @mbed-ci @AnttiKauppila @mirelachirica @cmonr