tools/utils: ensure default build profiles are processed first #9724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix for #8498 |
The command-line argument '--profile' looks for build profiles provided in mbed-os/tools/profiles/. If a directory name exists in the root folder with the same name as one of the profile names provided by default [e.g debug/develop/release], that directory is processed instead resulting in incorrect behavior. Fix this behavior by processing the default profiles first.
naveenkaje
force-pushed
the
tools_dir_with_profile_name
branch
from
db5c302 to
176b750
Compare
|
@naveenkaje, thank you for your changes. |
theotherjimmy
approved these changes
Feb 14, 2019
bridadan
approved these changes
Feb 14, 2019
|
CI started |
Test run: SUCCESSSummary: 12 of 12 test jobs passed |
cmonr
approved these changes
Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The command-line argument --profile looks for build profiles provided in mbed-os/tools/profiles/. If a
directory exists in the root folder with the same name as one of the profile names provided by default [e.g debug/develop/release], that directory is processed instead, resulting in an error. Fix this behavior by processing the default profiles first.
Pull request type
Reviewers
@theotherjimmy @bridadan