Deprecating receive(uint32_t) API

We are deprecating receive(uint32_t) API in favour of receive(void)
API because we are ditching software timeout timers in the driver
for RX chain.

Author: Hasnain Virk

SX1272/SX1272_LoRaRadio.cpp

@@ -865,7 +865,7 @@ void SX1272_LoRaRadio::transmit(uint32_t timeout)
  * and finally a DIO0 interrupt let's the state machine know that a packet is
  * ready to be read from the FIFO
  */
-void SX1272_LoRaRadio::receive(uint32_t)
+void SX1272_LoRaRadio::receive(void)
 {
     switch (_rf_settings.modem) {
         case MODEM_FSK:

SX1272/SX1272_LoRaRadio.h

@@ -192,18 +192,21 @@ class SX1272_LoRaRadio: public LoRaRadio {
     virtual void send(uint8_t *buffer, uint8_t size);
 
     /**
-     *  Sets the radio in reception mode for the given time
-     *
-     *  It should be noted that if the timeout is set to 0, it essentially
-     *  puts the receiver in continuous mode and hence from thereon it should
-     *  be treated as if in continuous mode. However, an appropriate way of
-     *  setting the receiver in continuous mode is by using set_rx_config()
-     *  API.
-     *
-     *  @param timeout       Reception timeout [ms]
+     * For backwards compatibility
+     */
+    virtual void receive(uint32_t timeout)
+    {
+        (void) timeout;
+        receive();
+    }
+
+    /**
+     * Sets the radio to receive
      *
+     * All necessary configuration options for receptions are set in
+     * 'set_rx_config(parameters)' API.
      */
-    virtual void receive(uint32_t /**timeout**/);
+    virtual void receive(void);
 
     /**
      *  Sets the carrier frequency

SX1276/SX1276_LoRaRadio.cpp

@@ -844,7 +844,7 @@ void SX1276_LoRaRadio::standby( void )
  * and finally a DIO0 interrupt let's the state machine know that a packet is
  * ready to be read from the FIFO
  */
-void SX1276_LoRaRadio::receive(uint32_t)
+void SX1276_LoRaRadio::receive(void)
 {
     switch (_rf_settings.modem) {
         case MODEM_FSK:

SX1276/SX1276_LoRaRadio.h

@@ -207,18 +207,21 @@ class SX1276_LoRaRadio: public LoRaRadio {
     virtual void send(uint8_t *buffer, uint8_t size);
 
     /**
-     *  Sets the radio in reception mode for the given time
-     *
-     *  It should be noted that if the timeout is set to 0, it essentially
-     *  puts the receiver in continuous mode and hence from thereon it should
-     *  be treated as if in continuous mode. However, an appropriate way of
-     *  setting the receiver in continuous mode is by using set_rx_config()
-     *  API.
-     *
-     *  @param timeout       Reception timeout [ms]
+     * For backwards compatibility
+     */
+    virtual void receive(uint32_t timeout)
+    {
+        (void) timeout;
+        receive();
+    }
+
+    /**
+     * Sets the radio to receive
      *
+     * All necessary configuration options for reception are set in
+     * 'set_rx_config(parameters)' API.
      */
-    virtual void receive(uint32_t /**timeout**/);
+    virtual void receive(void);
 
     /**
      *  Sets the carrier frequency