Skip to content

Commit edfa62d

Browse files
committed
[SYCL][NFC] align names of pi_device_info enumerators
Fixed inconsistency introduced by intel#860 In particular: - `PI_DEVICE_NAME` -> `PI_DEVICE_INFO_NAME` - `PI_DEVICE_MAX_WORK_GROUP_SIZE` -> `PI_DEVICE_INFO_MAX_WORK_GROUP_SIZE` Signed-off-by: Alexey Sachkov <[email protected]>
1 parent e0e01ca commit edfa62d

File tree

2 files changed

+13
-12
lines changed

2 files changed

+13
-12
lines changed

sycl/include/CL/sycl/detail/pi.h

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -85,14 +85,14 @@ typedef enum : pi_uint64 {
8585

8686
// TODO: populate and sync with cl::sycl::info::device
8787
typedef enum {
88-
PI_DEVICE_INFO_TYPE = CL_DEVICE_TYPE,
89-
PI_DEVICE_INFO_PARENT = CL_DEVICE_PARENT_DEVICE,
90-
PI_DEVICE_INFO_PLATFORM = CL_DEVICE_PLATFORM,
91-
PI_DEVICE_INFO_PARTITION_TYPE = CL_DEVICE_PARTITION_TYPE,
92-
PI_DEVICE_INFO_NAME = CL_DEVICE_NAME,
93-
PI_DEVICE_VERSION = CL_DEVICE_VERSION,
94-
PI_DEVICE_MAX_WORK_GROUP_SIZE = CL_DEVICE_MAX_WORK_GROUP_SIZE,
95-
PI_DEVICE_INFO_EXTENSIONS = CL_DEVICE_EXTENSIONS
88+
PI_DEVICE_INFO_TYPE = CL_DEVICE_TYPE,
89+
PI_DEVICE_INFO_PARENT = CL_DEVICE_PARENT_DEVICE,
90+
PI_DEVICE_INFO_PLATFORM = CL_DEVICE_PLATFORM,
91+
PI_DEVICE_INFO_PARTITION_TYPE = CL_DEVICE_PARTITION_TYPE,
92+
PI_DEVICE_INFO_NAME = CL_DEVICE_NAME,
93+
PI_DEVICE_INFO_VERSION = CL_DEVICE_VERSION,
94+
PI_DEVICE_INFO_MAX_WORK_GROUP_SIZE = CL_DEVICE_MAX_WORK_GROUP_SIZE,
95+
PI_DEVICE_INFO_EXTENSIONS = CL_DEVICE_EXTENSIONS
9696
} _pi_device_info;
9797

9898
// TODO: populate

sycl/source/detail/error_handling/enqueue_kernel.cpp

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,13 @@ bool handleInvalidWorkGroupSize(pi_device Device, pi_kernel Kernel,
2525
const bool HasLocalSize = (NDRDesc.LocalSize[0] != 0);
2626

2727
size_t VerSize = 0;
28-
PI_CALL(piDeviceGetInfo)(Device, PI_DEVICE_VERSION, 0, nullptr, &VerSize);
28+
PI_CALL(piDeviceGetInfo)(Device, PI_DEVICE_INFO_VERSION, 0, nullptr,
29+
&VerSize);
2930
assert(VerSize >= 10 &&
3031
"Unexpected device version string"); // strlen("OpenCL X.Y")
3132
string_class VerStr(VerSize, '\0');
32-
PI_CALL(piDeviceGetInfo)(Device, PI_DEVICE_VERSION, VerSize, &VerStr.front(),
33-
nullptr);
33+
PI_CALL(piDeviceGetInfo)(Device, PI_DEVICE_INFO_VERSION, VerSize,
34+
&VerStr.front(), nullptr);
3435
const char *Ver = &VerStr[7]; // strlen("OpenCL ")
3536

3637
size_t CompileWGSize[3] = {0};
@@ -69,7 +70,7 @@ bool handleInvalidWorkGroupSize(pi_device Device, pi_kernel Kernel,
6970
// than the value specified by CL_DEVICE_MAX_WORK_GROUP_SIZE in
7071
// table 4.3
7172
size_t MaxWGSize = 0;
72-
PI_CALL(piDeviceGetInfo)(Device, PI_DEVICE_MAX_WORK_GROUP_SIZE,
73+
PI_CALL(piDeviceGetInfo)(Device, PI_DEVICE_INFO_MAX_WORK_GROUP_SIZE,
7374
sizeof(size_t), &MaxWGSize, nullptr);
7475
const size_t TotalNumberOfWIs =
7576
NDRDesc.LocalSize[0] * NDRDesc.LocalSize[1] * NDRDesc.LocalSize[2];

0 commit comments

Comments
 (0)