Skip to content

Commit df60061

Browse files
KeyWeeUsrKeyWeeUsr
committed
Optimize Dockerfile
Prioritize SDK and NDK downloads before everything because once downloaded we don't care about redownloading unless the version is changed and layer cache works this way more efficiently. Redirect Licenses to /dev/null, move more important layers up. Move '&&' operators to the front - Docker sometimes, (personally I've encountered it only with apt and old coreutils), is very critical of the amount of spaces *after* the operator but does not care what's in front of it that much.
1 parent 5d4c974 commit df60061

File tree

1 file changed

+97
-47
lines changed

1 file changed

+97
-47
lines changed

‎Dockerfile

Lines changed: 97 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -1,82 +1,132 @@
11
# Dockerfile with:
22
# - Android build environment
33
# - python-for-android dependencies
4+
#
45
# Build with:
5-
# docker build --tag=p4a .
6+
# docker build --tag=p4a .
7+
#
68
# Run with:
7-
# docker run p4a /bin/sh -c '. venv/bin/activate && p4a apk --help'
9+
# docker run -it --rm p4a /bin/sh -c '. venv/bin/activate && p4a apk --help'
10+
#
811
# Or for interactive shell:
9-
# docker run -it --rm p4a
12+
# docker run -it --rm p4a
13+
#
14+
# Note:
15+
# Use 'docker run' without '--rm' flag for keeping the container and use
16+
# 'docker commit <container hash> <new image>' to extend the original image
17+
1018
FROM ubuntu:18.04
1119

20+
ENV ANDROID_HOME="/opt/android"
1221

13-
ENV USER="user"
14-
ENV HOME_DIR="/home/${USER}"
15-
ENV WORK_DIR="${HOME_DIR}" \
16-
PATH="${HOME_DIR}/.local/bin:${PATH}"
17-
# get the latest version from https://developer.android.com/ndk/downloads/index.html
22+
RUN apt -y update -qq \
23+
&& apt -y install -qq --no-install-recommends curl unzip \
24+
&& apt -y autoremove \
25+
&& apt -y clean
26+
27+
28+
ENV ANDROID_NDK_HOME="${ANDROID_HOME}/android-ndk"
1829
ENV ANDROID_NDK_VERSION="16b"
19-
# get the latest version from https://developer.android.com/studio/index.html
20-
ENV ANDROID_SDK_TOOLS_VERSION="3859397"
30+
ENV ANDROID_NDK_HOME_V="${ANDROID_NDK_HOME}-r${ANDROID_NDK_VERSION}"
2131

22-
ENV ANDROID_HOME="/opt/android"
23-
ENV ANDROID_NDK_HOME="${ANDROID_HOME}/android-ndk" \
24-
ANDROID_SDK_HOME="${ANDROID_HOME}/android-sdk"
25-
ENV ANDROID_NDK_HOME_V="${ANDROID_NDK_HOME}-r${ANDROID_NDK_VERSION}" \
26-
ENV ANDROID_NDK_ARCHIVE="android-ndk-r${ANDROID_NDK_VERSION}-linux-x86_64.zip" \
27-
ANDROID_SDK_TOOLS_ARCHIVE="sdk-tools-linux-${ANDROID_SDK_TOOLS_VERSION}.zip"
28-
ENV ANDROID_NDK_DL_URL="https://dl.google.com/android/repository/${ANDROID_NDK_ARCHIVE}" \
29-
ANDROID_SDK_TOOLS_DL_URL="https://dl.google.com/android/repository/${ANDROID_SDK_TOOLS_ARCHIVE}"
32+
# get the latest version from https://developer.android.com/ndk/downloads/index.html
33+
ENV ANDROID_NDK_ARCHIVE="android-ndk-r${ANDROID_NDK_VERSION}-linux-x86_64.zip"
34+
ENV ANDROID_NDK_DL_URL="https://dl.google.com/android/repository/${ANDROID_NDK_ARCHIVE}"
3035

31-
# install system dependencies
32-
RUN apt update -qq && apt install -qq --yes --no-install-recommends \
33-
python virtualenv python-pip wget curl lbzip2 patch bsdtar sudo && \
34-
rm -rf /var/lib/apt/lists/*
36+
# download and install Android NDK
37+
RUN curl --location --progress-bar --insecure \
38+
"${ANDROID_NDK_DL_URL}" \
39+
--output "${ANDROID_NDK_ARCHIVE}" \
40+
&& mkdir --parents "${ANDROID_NDK_HOME_V}" \
41+
&& unzip -q "${ANDROID_NDK_ARCHIVE}" -d "${ANDROID_HOME}" \
42+
&& ln -sfn "${ANDROID_NDK_HOME_V}" "${ANDROID_NDK_HOME}" \
43+
&& rm -rf "${ANDROID_NDK_ARCHIVE}"
3544

36-
# build dependencies
37-
# https://buildozer.readthedocs.io/en/latest/installation.html#android-on-ubuntu-16-04-64bit
38-
RUN dpkg --add-architecture i386 && apt update -qq && apt install -qq --yes --no-install-recommends \
39-
build-essential ccache git libncurses5:i386 libstdc++6:i386 libgtk2.0-0:i386 \
40-
libpangox-1.0-0:i386 libpangoxft-1.0-0:i386 libidn11:i386 python2.7 python2.7-dev \
41-
openjdk-8-jdk zip unzip zlib1g-dev zlib1g:i386
4245

43-
# specific recipes dependencies (e.g. libffi requires autoreconf binary)
44-
RUN apt install -qq --yes --no-install-recommends \
45-
autoconf automake cmake gettext libltdl-dev libtool pkg-config && \
46-
rm -rf /var/lib/apt/lists/*
46+
ENV ANDROID_SDK_HOME="${ANDROID_HOME}/android-sdk"
4747

48-
# download and install Android NDK
49-
RUN curl --location --progress-bar "${ANDROID_NDK_DL_URL}" --output "${ANDROID_NDK_ARCHIVE}" && \
50-
mkdir --parents "${ANDROID_NDK_HOME_V}" && \
51-
unzip -q "${ANDROID_NDK_ARCHIVE}" -d "${ANDROID_HOME}" && \
52-
ln -sfn "${ANDROID_NDK_HOME_V}" "${ANDROID_NDK_HOME}" && \
53-
rm -rf "${ANDROID_NDK_ARCHIVE}"
48+
# get the latest version from https://developer.android.com/studio/index.html
49+
ENV ANDROID_SDK_TOOLS_VERSION="3859397"
50+
ENV ANDROID_SDK_TOOLS_ARCHIVE="sdk-tools-linux-${ANDROID_SDK_TOOLS_VERSION}.zip"
51+
ENV ANDROID_SDK_TOOLS_DL_URL="https://dl.google.com/android/repository/${ANDROID_SDK_TOOLS_ARCHIVE}"
5452

5553
# download and install Android SDK
56-
RUN curl --location --progress-bar "${ANDROID_SDK_TOOLS_DL_URL}" --output "${ANDROID_SDK_TOOLS_ARCHIVE}" && \
57-
mkdir --parents "${ANDROID_SDK_HOME}" && \
58-
unzip -q "${ANDROID_SDK_TOOLS_ARCHIVE}" -d "${ANDROID_SDK_HOME}" && \
59-
rm -rf "${ANDROID_SDK_TOOLS_ARCHIVE}"
54+
RUN curl --location --progress-bar --insecure \
55+
"${ANDROID_SDK_TOOLS_DL_URL}" \
56+
--output "${ANDROID_SDK_TOOLS_ARCHIVE}" \
57+
&& mkdir --parents "${ANDROID_SDK_HOME}" \
58+
&& unzip -q "${ANDROID_SDK_TOOLS_ARCHIVE}" -d "${ANDROID_SDK_HOME}" \
59+
&& rm -rf "${ANDROID_SDK_TOOLS_ARCHIVE}"
6060

6161
# update Android SDK, install Android API, Build Tools...
62-
RUN mkdir --parents "${ANDROID_SDK_HOME}/.android/" && \
63-
echo '### User Sources for Android SDK Manager' > "${ANDROID_SDK_HOME}/.android/repositories.cfg"
64-
RUN yes | "${ANDROID_SDK_HOME}/tools/bin/sdkmanager" --licenses
62+
RUN mkdir --parents "${ANDROID_SDK_HOME}/.android/" \
63+
&& echo '### User Sources for Android SDK Manager' \
64+
> "${ANDROID_SDK_HOME}/.android/repositories.cfg"
65+
66+
# accept Android licenses (JDK necessary!)
67+
RUN apt -y update -qq \
68+
&& apt -y install -qq --no-install-recommends openjdk-8-jdk \
69+
&& apt -y autoremove \
70+
&& apt -y clean
71+
RUN yes | "${ANDROID_SDK_HOME}/tools/bin/sdkmanager" --licenses > /dev/null
72+
73+
# download platforms, API, build tools
6574
RUN "${ANDROID_SDK_HOME}/tools/bin/sdkmanager" "platforms;android-19" && \
6675
"${ANDROID_SDK_HOME}/tools/bin/sdkmanager" "platforms;android-27" && \
6776
"${ANDROID_SDK_HOME}/tools/bin/sdkmanager" "build-tools;26.0.2" && \
6877
chmod +x "${ANDROID_SDK_HOME}/tools/bin/avdmanager"
6978

79+
80+
ENV USER="user"
81+
ENV HOME_DIR="/home/${USER}"
82+
ENV WORK_DIR="${HOME_DIR}" \
83+
PATH="${HOME_DIR}/.local/bin:${PATH}"
84+
85+
# install system dependencies
86+
RUN apt -y update -qq \
87+
&& apt -y install -qq --no-install-recommends \
88+
python virtualenv python-pip wget lbzip2 patch sudo \
89+
&& apt -y autoremove \
90+
&& apt -y clean
91+
92+
# build dependencies
93+
# https://buildozer.readthedocs.io/en/latest/installation.html#android-on-ubuntu-16-04-64bit
94+
RUN dpkg --add-architecture i386 \
95+
&& apt -y update -qq \
96+
&& apt -y install -qq --no-install-recommends \
97+
build-essential ccache git python2.7 python2.7-dev \
98+
libncurses5:i386 libstdc++6:i386 libgtk2.0-0:i386 \
99+
libpangox-1.0-0:i386 libpangoxft-1.0-0:i386 libidn11:i386 \
100+
zip zlib1g-dev zlib1g:i386 \
101+
&& apt -y autoremove \
102+
&& apt -y clean
103+
104+
# specific recipes dependencies (e.g. libffi requires autoreconf binary)
105+
RUN apt -y update -qq \
106+
&& apt -y install -qq --no-install-recommends \
107+
autoconf automake cmake gettext libltdl-dev libtool pkg-config \
108+
&& apt -y autoremove \
109+
&& apt -y clean
110+
111+
70112
# prepare non root env
71113
RUN useradd --create-home --shell /bin/bash ${USER}
114+
72115
# with sudo access and no password
73116
RUN usermod -append --groups sudo ${USER}
74117
RUN echo "%sudo ALL=(ALL) NOPASSWD: ALL" >> /etc/sudoers
75-
RUN pip install --quiet --upgrade cython==0.28.6
118+
119+
120+
RUN pip install --upgrade cython==0.28.6
121+
76122
WORKDIR ${WORK_DIR}
77123
COPY . ${WORK_DIR}
124+
78125
# user needs ownership/write access to these directories
79126
RUN chown --recursive ${USER} ${WORK_DIR} ${ANDROID_SDK_HOME}
80127
USER ${USER}
128+
81129
# install python-for-android from current branch
82-
RUN virtualenv --python=python venv && . venv/bin/activate && pip install --quiet -e .
130+
RUN virtualenv --python=python venv \
131+
&& . venv/bin/activate \
132+
&& pip install -e .

0 commit comments

Comments
 (0)